AuroraMiddleware/harfbuzz
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge pull request #886 from madig/only-export-visible-symbols

Browse Source 
CMake: hide symbols by default on non-MSVC, define export attribute
This commit is contained in:
Ebrahim Byagowi 2018-03-15 11:40:52 +03:30 committed by GitHub
commit 791d80a1d4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 23 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
CMakeLists.txt
View File

@ -1,4 +1,7 @@
cmake_minimum_required(VERSION 2.8.0) cmake_minimum_required(VERSION 2.8.0)
# Allow symbol hiding for both static and shared libs.
cmake_policy(SET CMP0063 NEW)
project(harfbuzz) project(harfbuzz)
enable_testing() enable_testing()
@ -131,14 +134,6 @@ if (MSVC)
add_definitions(-wd4244 -wd4267 -D_CRT_SECURE_NO_WARNINGS -D_CRT_NONSTDC_NO_WARNINGS) add_definitions(-wd4244 -wd4267 -D_CRT_SECURE_NO_WARNINGS -D_CRT_NONSTDC_NO_WARNINGS)
endif () endif ()
if (BUILD_SHARED_LIBS)
if (WIN32 AND NOT MINGW)
add_definitions("-DHB_EXTERN=__declspec(dllexport) extern")
else ()
set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fvisibility-inlines-hidden")
endif ()
endif ()
## Detect if we are running inside a distribution or regular repository folder ## Detect if we are running inside a distribution or regular repository folder
# if (EXISTS "${PROJECT_SOURCE_DIR}/ChangeLog") # if (EXISTS "${PROJECT_SOURCE_DIR}/ChangeLog")
@ -532,11 +527,19 @@ endif ()
## Define harfbuzz library ## Define harfbuzz library
add_library(harfbuzz ${project_sources} ${project_extra_sources} ${project_headers}) add_library(harfbuzz ${project_sources} ${project_extra_sources} ${project_headers})
set_target_properties(harfbuzz PROPERTIES
C_VISIBILITY_PRESET hidden
CXX_VISIBILITY_PRESET hidden
VISIBILITY_INLINES_HIDDEN TRUE)
target_link_libraries(harfbuzz ${THIRD_PARTY_LIBS}) target_link_libraries(harfbuzz ${THIRD_PARTY_LIBS})
## Define harfbuzz-subset library ## Define harfbuzz-subset library
add_library(harfbuzz-subset ${subset_project_sources} ${subset_project_headers}) add_library(harfbuzz-subset ${subset_project_sources} ${subset_project_headers})
add_dependencies(harfbuzz-subset harfbuzz) add_dependencies(harfbuzz-subset harfbuzz)
set_target_properties(harfbuzz-subset PROPERTIES
C_VISIBILITY_PRESET hidden
CXX_VISIBILITY_PRESET hidden
VISIBILITY_INLINES_HIDDEN TRUE)
target_link_libraries(harfbuzz-subset harfbuzz ${THIRD_PARTY_LIBS}) target_link_libraries(harfbuzz-subset harfbuzz ${THIRD_PARTY_LIBS})
if (UNIX OR MINGW) if (UNIX OR MINGW)
@ -564,11 +567,23 @@ if (HB_HAVE_GOBJECT)
${hb_gobject_headers} ${hb_gobject_headers}
${hb_gobject_gen_headers} ${hb_gobject_gen_headers}
) )
set_target_properties(harfbuzz-gobject PROPERTIES
C_VISIBILITY_PRESET hidden
CXX_VISIBILITY_PRESET hidden
VISIBILITY_INLINES_HIDDEN TRUE)
include_directories(BEFORE ${CMAKE_CURRENT_BINARY_DIR}/src) include_directories(BEFORE ${CMAKE_CURRENT_BINARY_DIR}/src)
add_dependencies(harfbuzz-gobject harfbuzz) add_dependencies(harfbuzz-gobject harfbuzz)
target_link_libraries(harfbuzz-gobject harfbuzz ${GOBJECT_LIBRARIES} ${THIRD_PARTY_LIBS}) target_link_libraries(harfbuzz-gobject harfbuzz ${GOBJECT_LIBRARIES} ${THIRD_PARTY_LIBS})
endif () endif ()
if (BUILD_SHARED_LIBS)
if (WIN32 AND NOT MINGW)
add_definitions("-DHB_EXTERN=__declspec(dllexport) extern")
else ()
add_definitions("-DHB_EXTERN=__attribute__(( visibility( \"default\" ) )) extern")
endif ()
endif ()
# On Windows, g-ir-scanner requires a DLL build in order for it to work # On Windows, g-ir-scanner requires a DLL build in order for it to work
if (WIN32) if (WIN32)
if (NOT BUILD_SHARED_LIBS) if (NOT BUILD_SHARED_LIBS)