AuroraMiddleware/harfbuzz
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[set/map] Fix uninitialized memory

Browse Source 
I keep forgetting that primitive types are NOT initialized during construction. :|
This commit is contained in:
Behdad Esfahbod 2018-10-29 23:21:14 -07:00
parent ad3cededdd
commit b186274362
3 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/hb-map.hh
View File

@ -45,8 +45,8 @@ inline uint32_t Hash (const T &v)
struct hb_map_t struct hb_map_t
{ {
HB_NO_COPY_ASSIGN (hb_map_t); HB_NO_COPY_ASSIGN (hb_map_t);
inline hb_map_t (void) { init_shallow (); } inline hb_map_t (void) { init (); }
inline ~hb_map_t (void) { fini_shallow (); } inline ~hb_map_t (void) { fini (); }
struct item_t struct item_t
{ {

1
src/hb-object.hh
View File

@ -272,6 +272,7 @@ static inline void hb_object_fini (Type *obj)
{ {
user_data->fini (); user_data->fini ();
free (user_data); free (user_data);
user_data = nullptr;
} }
} }
template <typename Type> template <typename Type>

4
src/hb-set.hh
View File

@ -40,8 +40,8 @@
struct hb_set_t struct hb_set_t
{ {
HB_NO_COPY_ASSIGN (hb_set_t); HB_NO_COPY_ASSIGN (hb_set_t);
inline hb_set_t (void) { init_shallow (); } inline hb_set_t (void) { init (); }
inline ~hb_set_t (void) { fini_shallow (); } inline ~hb_set_t (void) { fini (); }
struct page_map_t struct page_map_t
{ {