AuroraMiddleware/harfbuzz
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[dwrite] Release allocated blob on face destroy

Browse Source 
This reduces memory consumption of my iterated font create/destroy cycle test
significantly and makes it much better than uniscribe backend even
This commit is contained in:
Ebrahim Byagowi 2016-06-24 11:42:01 +04:30
parent f3f0ea980a
commit be565d1714
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/hb-directwrite.cc
View File

@ -134,6 +134,7 @@ struct hb_directwrite_shaper_face_data_t {
IDWriteFontFile* fontFile; IDWriteFontFile* fontFile;
IDWriteFontFileLoader* fontFileLoader; IDWriteFontFileLoader* fontFileLoader;
IDWriteFontFace* fontFace; IDWriteFontFace* fontFace;
hb_blob_t* faceBlob;
}; };
hb_directwrite_shaper_face_data_t * hb_directwrite_shaper_face_data_t *
@ -153,7 +154,7 @@ _hb_directwrite_shaper_face_data_create(hb_face_t *face)
); );
HRESULT hr; HRESULT hr;
hb_blob_t* blob = hb_face_reference_blob (face); hb_blob_t *blob = hb_face_reference_blob (face);
IDWriteFontFileStream *fontFileStream = new DWriteFontFileStream ( IDWriteFontFileStream *fontFileStream = new DWriteFontFileStream (
(uint8_t*) hb_blob_get_data (blob, NULL), hb_blob_get_length (blob)); (uint8_t*) hb_blob_get_data (blob, NULL), hb_blob_get_length (blob));
@ -196,6 +197,7 @@ _hb_directwrite_shaper_face_data_create(hb_face_t *face)
data->fontFile = fontFile; data->fontFile = fontFile;
data->fontFileLoader = fontFileLoader; data->fontFileLoader = fontFileLoader;
data->fontFace = fontFace; data->fontFace = fontFace;
data->faceBlob = blob;
return data; return data;
} }
@ -205,6 +207,7 @@ _hb_directwrite_shaper_face_data_destroy(hb_directwrite_shaper_face_data_t *data
{ {
data->dwriteFactory->UnregisterFontFileLoader (data->fontFileLoader); data->dwriteFactory->UnregisterFontFileLoader (data->fontFileLoader);
delete data->fontFileLoader; delete data->fontFileLoader;
hb_blob_destroy (data->faceBlob);
free (data); free (data);
} }