Improve overflow avoidance

Better fix for 480406cd3e
This way we behave the same on 32bit and 64bit archs.
This commit is contained in:
Behdad Esfahbod 2019-01-15 13:58:19 -05:00
parent 0d2727f4fe
commit c986ca15a6

View File

@ -268,16 +268,12 @@ struct hb_sanitize_context_t :
if (!obj) return;
const char *obj_start = (const char *) obj;
const char *obj_end = (const char *) obj + obj->get_size ();
if (unlikely (obj_end < obj_start /* Overflow. */ ||
obj_end < this->start ||
this->end < obj_start))
if (unlikely (obj_start < this->start || this->end <= obj_start))
this->start = this->end = nullptr;
else
{
this->start = MAX (this->start, obj_start);
this->end = MIN (this->end , obj_end );
this->start = obj_start;
this->end = obj_start + MIN<uintptr_t> (this->end - obj_start, obj->get_size ());
}
}