AuroraMiddleware/harfbuzz
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
11,097 Commits 1 Branch 0 Tags 55 MiB
5aff83104e
Commit Graph

8807 Commits

Author SHA1 Message Date
Ebrahim Byagowi
efd716de3f [cff] Check for scalars array resize result 
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=24504
 2020-07-31 09:27:27 +04:30
Garret Rieger
040ed094ef [ENOMEM] popragate packed/packed_map errors to the serializer. 
Will disable further modifications based on a bad state.
 2020-07-31 08:39:26 +04:30
Garret Rieger
7f358a55f4 [ENOMEM] unchecked resize in CFF2. 2020-07-31 02:04:06 +04:30
Garret Rieger
32f052b033 [ENOMEM] Fix several instances of not checking resize in CFF. 2020-07-31 02:04:06 +04:30
Garret Rieger
4cbc7d61bc [ENOMEM] check for unset current in serializer->length(). 2020-07-31 02:04:06 +04:30
Garret Rieger
15644ee60e [ENOMEM] fix memory leak if allocation fails during pop_pack(). 2020-07-30 04:15:35 +04:30
Garret Rieger
42237adffc [ENOMEM] make serializer modification operations no-ops if it's in an error state. 2020-07-30 03:59:49 +04:30
Ebrahim Byagowi
d1f1301490
[icu] Remove support for versions older than 49 
It just doesn't make sense anymore, c9e5da8ded (r41018112)
 2020-07-30 02:01:43 +04:30
Ebrahim Byagowi
0b74aaece7
[icu] Remove useless HB_UNUSED tags 
As c9e5da8ded (r41018040)
 2020-07-30 01:47:30 +04:30
Ebrahim Byagowi
c9e5da8ded [icu] Remove support of ICU versions before 42 
ICU 42 is released in 2012, see also 44a3136ae6 (commitcomment-41016353)
 2020-07-30 01:03:07 +04:30
Garret Rieger
4ba8e3c6fd [ENOMEM] Fix failure to check calloc return. 
Fixes https://oss-fuzz.com/testcase-detail/6246465148813312.
 2020-07-30 00:08:08 +04:30
Garret Rieger
d307c24abf [ENOMEM] check resize() return. 
Fixes https://oss-fuzz.com/testcase-detail/5641892164009984.
 2020-07-30 00:08:08 +04:30
Ebrahim Byagowi
58a5961ca1 minor spacing tweak 2020-07-29 08:44:23 +04:30
Ebrahim Byagowi
07c43b8cf6 minor spacing tweak 2020-07-29 08:42:52 +04:30
Ebrahim Byagowi
5a7cc7fd8b minor spacing tweak 2020-07-29 08:33:38 +04:30
Ebrahim Byagowi
48ad745996 [ENOMEM] Fix buffer's content check logic 
So now rest of shape fuzzer also can be enabled.

Fixes #2571
 2020-07-29 08:09:10 +04:30
Ebrahim Byagowi
c33e8006fd [fuzz] Implement failing allocator 2020-07-29 07:35:34 +04:30
Ebrahim Byagowi
44a3136ae6 [glib] Default to glib's script type handling 
2.29.14 is almost released a decade ago, no need to support archaic glib versions.
 2020-07-29 07:05:31 +04:30
Garret Rieger
dae32b4f12 [subset] bail out of subsetting if plan allocation fails. 2020-07-29 06:37:25 +04:30
Ebrahim Byagowi
a01c7a380b 2.7.0 2020-07-25 12:40:57 +04:30
Evgeniy Reizner
b32f2e8b49 Remove unused code from the Khmer shaper. 2020-07-24 20:38:05 +04:30
Ebrahim Byagowi
46ec6db965 minor 2020-07-22 17:30:48 +04:30
insilications
83c44f69d3 [tests] fix PGO build testing 
Adds 'mangle_path' to IGNORED_SYMBOLS
 2020-07-21 03:05:28 +04:30
Ebrahim Byagowi
d0e2addd43 minor 2020-07-18 22:16:02 +04:30
Ebrahim Byagowi
7e3edfa454
minor 2020-07-18 19:03:36 +04:30
Qunxin Liu
8e5bc535d1 [subset] call collect_mapping only when --gids option is used. 
collect_mapping is time consuming as it iterates all codepoints in all
cmap subtables, only trigger it when necessary
 2020-07-16 11:25:53 -07:00
Ebrahim Byagowi
7c433ffde2
Add HB_CUSTOM_MALLOC definition 
So one can use just HB_CUSTOM_MALLOC instead need for define each of hb_*alloc_impl
 2020-07-15 09:38:12 +04:30
Ebrahim Byagowi
60959b08e5
[meson] execute find_program('gen-ragel-artifacts.py') only once 
should rename the script also
 2020-07-14 20:28:06 +04:30
Ebrahim Byagowi
5c8e1bd237 [meson] Don't allow introspection on static library 2020-07-14 18:02:40 +04:30
Ebrahim Byagowi
9566904cb3
[morx] minor, mark with unlikely 
at least just to show this is the unusual path
 2020-07-14 15:17:17 +04:30
Ebrahim Byagowi
11d583a9ea
[aat] Consume glyph insertion from buffer's max_ops (#2223) 
Glyph insertion is an expensive operation and we like to have it limited
based on buffer's input size which is handled by buffer's max_ops.

clusterfuzz-testcase-minimized-harfbuzz_fuzzer-5754958982021120:

Before the change: 0.67s user 0.00s system 99% cpu 0.674 total
 After the change: 0.02s user 0.00s system 98% cpu 0.024 total

Which takes much longer on valgrind and tsan bots.
 2020-07-13 18:53:06 -07:00
Ebrahim Byagowi
6937092a66 [py] apply lgtm.com python suggestions 2020-07-13 23:37:52 +04:30
Ebrahim Byagowi
2a182128b9
[py] minor, comment buffer_add_utf8 call 
mainly to apply lgtm suggestion, looks better also however,
some minor spacing is also applied.
 2020-07-13 20:41:13 +04:30
Ebrahim Byagowi
cdf18e8338
[py] minor, remove unnecessary pass 
discovered by lgtm
 2020-07-13 20:07:51 +04:30
Ebrahim Byagowi
45d9e8d76c
[py] minor, remove unused import 2020-07-13 19:25:53 +04:30
Behdad Esfahbod
1dfa33854f [arabic] Remove stale comment 2020-07-12 09:24:03 -07:00
Behdad Esfahbod
6a45df0a54 Fix -Wambiguous-reversed-operator warning 
Fixes https://github.com/harfbuzz/harfbuzz/issues/2554
 2020-07-08 18:17:40 -05:00
jfkthame
1e6027e29c
[aat] Correct array indexing when looking up actions in KerxSubTableFormat4 (#2539) 
* [aat] Correct array indexing when looking up actions in KerxSubTableFormat4.

- For action_type 0 and 1, there are 2 values per action record; for action_type 2, there are 4. So we need to account for these factors when indexing into the ankrData array.

Fixes https://github.com/harfbuzz/harfbuzz/issues/2531.
 2020-07-05 22:44:10 +01:00
Ebrahim Byagowi
122a2897e4 [aat] Remove lcar support 
Very low use, only two distinct font files, Apple Chancery.ttf and Hoefler Text.ttc
have it so it really doesn't worth the size addition and so, but one may argue that
whole ligature caret is low use but guess we better to encourage GDEF one anyway.
 2020-07-06 00:05:36 +04:30
Ebrahim Byagowi
a3b9b94b63
[style] Remove fdsc support (#2541) 
It isn't exposed yet and low use between Apple fonts,
32 fdsc table vs 767 OS/2 tables, even Apple doesn't
support it anymore per Ned.
 2020-07-06 00:05:21 +04:30
Ebrahim Byagowi
a6fb8ce98a Minor, fix -Wrange-loop-analysis warnings 
Fixing these complains raised by newer versions of clang,

./hb-ot-layout-common.hh:1720:53: error: loop variable 'gid_klass_pair' is always a copy because the range of type 'hb_map_iter_t<hb_sorted_array_t<OT::HBGlyphID>, (lambda at ./hb-ot-layout-common.hh:1672:29), hb_function_sortedness_t::RETAINS_SORTING, nullptr>' does not return a reference [-Werror,-Wrange-loop-analysis]
    for (const hb_pair_t<hb_codepoint_t, unsigned>& gid_klass_pair : + it)

And

./hb-ot-color-colr-table.hh:177:44: error: loop variable '_' is always a copy because the range of type 'hb_map_iter_t<hb_filter_iter_t<hb_map_iter_t<hb_range_iter_t<unsigned int, unsigned int>, (lambda at ./hb-ot-color-colr-table.hh:209:31), hb_function_sortedness_t::RETAINS_SORTING, nullptr>, (anonymous struct at ./hb-algs.hh:331:1) &, (anonymous struct at ./hb-algs.hh:51:1) &, nullptr>, (anonymous struct at ./hb-algs.hh:338:1) &, hb_function_sortedness_t::RETAINS_SORTING, nullptr>' does not return a reference [-Werror,-Wrange-loop-analysis]
    for (const hb_item_type<BaseIterator>& _ : + base_it.iter ())
 2020-07-05 11:18:04 +04:30
Jan Alexander Steffens (heftig)
4444482297 meson: Pin harfbuzz in .pc files to the built version 
This ensures that we link -subset, -icu and -gobject with a matching
version of the main library.
 2020-07-04 23:16:09 +04:30
Jan Alexander Steffens (heftig)
3adcf398a0 meson: Make Requires in .pc files match autotools 
Libreoffice tries to use only harfbuzz-icu.pc and assumes this includes
-lharfbuzz.
 2020-07-04 23:16:09 +04:30
Ebrahim Byagowi
6a2b0ba78a [py] minor, replace exit with sys.exit 2020-07-04 16:16:15 +04:30
Ebrahim Byagowi
a07672d353 [py] minor, replace os.environ.get with os.getenv 2020-07-04 16:16:15 +04:30
Ebrahim Byagowi
359dbc97ae [meson] Use the recommended way to generate harfbuzz.cc 
As https://github.com/harfbuzz/harfbuzz/pull/2532
 2020-07-04 13:55:48 +04:30
Ebrahim Byagowi
a7e82e4ffd [meson] use the recommended way to generate hb-version.h 
As https://github.com/harfbuzz/harfbuzz/pull/2532
 2020-07-04 13:55:48 +04:30
Ebrahim Byagowi
404ecc252c [meson] use basename in check scripts now that meson passes dir also 2020-07-04 13:55:48 +04:30
Ebrahim Byagowi
785a9a8f8a [meson] use the recommended way to generate ragel headers 
As described in https://github.com/mesonbuild/meson/issues/7156#issuecomment-629622827
 2020-07-04 13:55:48 +04:30
Ebrahim Byagowi
5c07c291c7
[make] use sed the way autotools used to generate hb-version.h 
Left from 1853f84 and now exactly is like 4fc6189a32
 2020-07-04 04:33:46 +04:30
Ebrahim Byagowi
63322513e4
[make] Revert the way harfbuzz.cc and hb-version.h are generated 
Partially reverts 4fc6189
 2020-07-04 03:34:58 +04:30
Ebrahim Byagowi
1853f84abc [py] overwrite harfbuzz.cc only when there is a needed change 2020-07-03 15:51:13 +04:30
Ebrahim Byagowi
82c6ddb986 [py] remove not needed imports 2020-07-03 15:51:13 +04:30
Ebrahim Byagowi
42d039cc99 [meson] minor 2020-07-03 04:49:12 +04:30
Ebrahim Byagowi
f2a80ab2c2 [meson] use null_dep idiom 2020-07-03 04:49:12 +04:30
Ebrahim Byagowi
d543923294
[fvar] minor 2020-07-02 01:30:24 +04:30
Hugo Beauzée-Luyssen
40ec187dec win32: Cleanup PARTITION handling 
Use the WINAPI_PARTITION macro to filter desktop/app flavors.
We use a negated desktop check because the default (for mingw-w64 at
least) is to allow all API by combining desktop + app partitions.
This causes build failures if we were to filter using
WINAPI_PARTITION(WINAPI_FAMILY_APP) because it would always be true, but
those API also require Windows 8 or later, while we only require Vista

Fixes warnings like
../src/hb-blob.cc:572:47: warning: 'WINAPI_FAMILY_PC_APP' is not defined, evaluates to 0 [-Wundef]
 #if defined(WINAPI_FAMILY) && (WINAPI_FAMILY==WINAPI_FAMILY_PC_APP || WINAPI_FAMILY==WINAPI_FAMILY_PHONE_APP)
                                              ^
../src/hb-blob.cc:572:86: warning: 'WINAPI_FAMILY_PHONE_APP' is not defined, evaluates to 0 [-Wundef]
 #if defined(WINAPI_FAMILY) && (WINAPI_FAMILY==WINAPI_FAMILY_PC_APP || WINAPI_FAMILY==WINAPI_FAMILY_PHONE_APP)
 2020-07-01 13:05:14 +04:30
Ebrahim Byagowi
ea8e784146 [fvar] Improve naming 2020-07-01 01:33:02 +04:30
Ebrahim Byagowi
5de07b8acd [fvar] Move normalize logic where it is actually filled 2020-07-01 01:33:02 +04:30
Ebrahim Byagowi
0f8dda2cf2 [fvar] Move shared axis filling values into a new method 2020-07-01 01:33:02 +04:30
Ebrahim Byagowi
98c42b3bc7 [fvar] Make AxisRecord fields protected 2020-07-01 01:33:02 +04:30
Behdad Esfahbod
7ee3194f98 [meta] Remove wrong comment 2020-06-28 15:41:44 -07:00
Behdad Esfahbod
26b9670d99 [ft] Better handle allocation failures 
Fixes https://github.com/harfbuzz/harfbuzz/issues/2513
 2020-06-28 14:52:15 -07:00
Behdad Esfahbod
26111a11ad [dagger] Minor cleanup using hb_enumerate 2020-06-28 13:26:38 -07:00
Ebrahim Byagowi
08d57d9eca
Add hb_array_t::lfind 2020-06-28 13:13:25 +04:30
Behdad Esfahbod
a783840789 Always round up 
Fixes https://github.com/harfbuzz/harfbuzz/issues/2496
 2020-06-28 13:10:37 +04:30
Sebastian Rasmussen
2267da4ee0
[ft] Do not deference ft_font if it is nullptr (#2502) 2020-06-27 20:18:16 -07:00
Sebastian Rasmussen
a373e16131
[ot-shape] Free shape plan maps upon error creating data (#2497) 2020-06-27 20:09:45 -07:00
Sebastian Rasmussen
dbf9896e7a
[ft] Handle nullptr when destroying freetype font (#2494) 2020-06-27 19:57:34 -07:00
Ebrahim Byagowi
76ba619daa Fix autotools's harfbuzz.cc build 
How this works? gen-harfbuzzcc.py operates at its own source path (see its 7th line)
and that is reliable when used both on meson and autotools.

Just like 19ecabed, weirdly this didn't come up sooner, guess it has something
to do with timestamps. Fortunately whole harfbuzz.cc just doesn't matter for
packagers but we can tag a release only for this if needed.
 2020-06-25 01:37:52 +04:30
Sebastian Rasmussen
12a9d57292
[face] Destroy blob if face closure can not be created (#2490) 
This fixes issue #2489.
 2020-06-23 12:25:43 -07:00
Ebrahim Byagowi
53b0a183c7 Remove concept of stable/unstable from build tools 
We never practiced the concept of stable and unstable releases, let's
remove the code and always use the stable scheme.
 2020-06-23 14:46:47 +04:30
Ebrahim Byagowi
e4203c1469 2.6.8 2020-06-22 12:51:22 +04:30
Ebrahim Byagowi
e541fb474c minor, replace single hb_apply daggers with foreach 2020-06-21 10:31:39 +04:30
Ebrahim Byagowi
8bca9a420e [fvar] minor 2020-06-21 09:18:12 +04:30
Ebrahim Byagowi
82ec9ef2e9 [fvar] minor simplification 2020-06-21 08:49:26 +04:30
Ebrahim Byagowi
4e37c48e37 [fvar] Remove get_axis_info and get_axis_deprecated 2020-06-21 08:49:26 +04:30
Ebrahim Byagowi
61c240f399 [fvar] Push _axis_info fill logic deeper 2020-06-21 08:49:26 +04:30
Ebrahim Byagowi
47a0fbec31 [meson] Mark longer tests with slow 
So one can skip them easily by `meson test -Cbuild --no-suite slow`
 2020-06-21 08:47:10 +04:30
Ebrahim Byagowi
b2d0dba5ef [cpal] Port to dagger 2020-06-20 22:06:19 +04:30
Ebrahim Byagowi
25cf687443
Use dagger in OffsetTable::get_table_tags (#2477) 2020-06-19 14:06:50 -07:00
Ebrahim Byagowi
dce4353f86
Merge pull request #2476 from ebraminio/cv-get-chars 
[layout] Use dagger in hb_ot_layout_feature_get_characters
 2020-06-20 01:24:41 +04:30
Ebrahim Byagowi
89a2c46e61
[math] Use dagger (#2478) 
* [math] Use dagger

* [ot-math] Address Behdad's review
 2020-06-19 13:01:46 -07:00
Ebrahim Byagowi
d38eb49f46 Move the iteration logic to FeatureParamsCharacterVariants 
Hopefully I can make members protected also.
 2020-06-19 23:46:49 +04:30
Ebrahim Byagowi
9b3d4f457e Use dagger in hb_ot_layout_feature_get_characters 
The way it used to work was a bit nonidiomatic but the replacment
is idiomatic way of iterating used elsewhere.

The new code just doesn't check nullability of "characters", which isn't
what we do anywhere else.
 2020-06-19 23:46:44 +04:30
Ebrahim Byagowi
63422c4cbc [ot-layout] simplify 2020-06-19 23:26:18 +04:30
Ebrahim Byagowi
407bba3e0d minor 
move FeatureParamsCharacterVariants::sanitize method right above members
 2020-06-19 23:12:56 +04:30
Ebrahim Byagowi
f1488152bd [doc] Remove the not needed comment 
All the other similar iterating API are like this and don't have such
comment, written at the time I wasn't familiar enough with the way such
API are shaped.
 2020-06-19 23:07:30 +04:30
Behdad Esfahbod
1535440b48 [dispatch] Fix debug builds 2020-06-19 08:32:57 -07:00
Ebrahim Byagowi
bb9a40da65 [lcar] Use dagger 2020-06-19 19:22:47 +04:30
Behdad Esfahbod
6fbb59aba6 Use daggers in a few get_array functions 
As I review https://github.com/harfbuzz/harfbuzz/pull/2471
 2020-06-19 00:05:52 -07:00
Ebrahim Byagowi
a512ca8eae
Merge pull request #2473 from harfbuzz/gsub-alternate 
fixes #673
 2020-06-19 10:46:12 +04:30
Behdad Esfahbod
70d6696cc6 [dispatch] Don't require debug_depth for untraced objects 2020-06-18 17:09:39 -07:00
Behdad Esfahbod
5bc4cedde6 Rename 2020-06-18 17:04:35 -07:00
Behdad Esfahbod
dc492d7c8a [dispatch] Comment 2020-06-18 17:03:05 -07:00
Behdad Esfahbod
25aec0265c [dispatch] Default return type to hb_empty_t 2020-06-18 16:58:01 -07:00
Behdad Esfahbod
8d0a90ac1b [dispatch] Default debug level to 0 2020-06-18 16:53:54 -07:00
Behdad Esfahbod
d7d8604ec8 Remove excessive trace routes 2020-06-18 16:51:24 -07:00
Behdad Esfahbod
e47a2ab8f8 Remove unused dispatcher names 2020-06-18 16:48:07 -07:00
Behdad Esfahbod
b2a1acccd9 Simplify get_glyph_alternates() dispatcher 
Trying to make it **very simple** to add a specialized dispatcher for
one API to be routed to just a few objects (one in this case).
 2020-06-18 16:41:31 -07:00