AuroraMiddleware/harfbuzz
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
11,667 Commits 1 Branch 0 Tags 55 MiB
89df353996
Commit Graph

1752 Commits

Author SHA1 Message Date
Garret Rieger
00d9276343 Add gpos9 expected files to Makefile.am 2021-02-11 13:41:31 -07:00
Garret Rieger
08a4997fde [subset] Add subset support for Extension lookups (GPOS 9, GSUB 7). 2021-02-11 13:41:31 -07:00
Behdad Esfahbod
eb069f3948 [tests] Update expected output of recently-merged gpos5 
The merged PR was from before landing this:

commit 7a72b20aa2
Author: Garret Rieger <grieger@google.com>
Date:   Thu Sep 24 15:58:48 2020 -0700

    [subset] Subset GDEF during layout subsetting tests.
 2021-02-10 19:13:51 -07:00
Behdad Esfahbod
c7d232ce4e
Merge pull request #2701 from googlefonts/Mark-To-Ligature_grieger 
[subset] GPOS 5 MarkToLigature subsetting support
 2021-02-10 18:13:38 -07:00
Khaled Hosny
554aaa0c5d [build] Fix make distcheck 
A regression from 7b77ce0507.
It was caught by the CI build in the PR, but apparently we are now used
to CI failures that they are effectively ignored.

Also, yay for multiple build systems.
 2021-02-10 23:22:02 +02:00
Behdad Esfahbod
6a3fd94f3b
Merge pull request #2699 from googlefonts/gpos_8 
[subset] Add a more complex layout subsetting test case and fix the issues it exposed.
 2021-02-09 20:49:04 -05:00
Behdad Esfahbod
33a0f0b686 [test] Remove fuzzed test font that triggers virus alert 
Fixes https://github.com/harfbuzz/harfbuzz/issues/2750
 2021-02-09 12:55:45 -07:00
Garret Rieger
f94bf9f06f [set fuzzer] limit the total number of set members in a fuzzing input. 
Currently the fuzzer can create arbitarily long inputs which once big enough will trigger a timeout.
 2021-01-26 10:22:07 -08:00
Garret Rieger
a4c3732f59 [ENOMEM] fix set clear() causing corruption if the set is in_error(). 2021-01-21 12:12:05 -07:00
David Corbett
b2e7bb2a7c Don’t map BCP 47 to coincidentally similar OT tag 2020-11-22 19:35:47 -08:00
David Corbett
17da41bd06 Update language system tag registry to OT 1.8.4 2020-11-18 11:13:35 -08:00
Khaled Hosny
c2cdcd4901 [tests] warning: unused variable 'num_glyphs' 2020-10-17 21:57:27 +02:00
David Corbett
0792690b73 [use] Skip WJ and ZWJ when clustering 2020-10-16 22:39:46 -07:00
Khaled Hosny
84dd65a874 [test] Remove timeout from test runners 
See https://github.com/harfbuzz/harfbuzz/issues/2707#issuecomment-707744079

This wasn’t inconsistent as well, HB_TEST_SUBSET_FUZZER_TIMEOUT defaulted
to 12 in the test runner, but it was overridden to 50 in meson.build,
and then meson has its own test timeout.
 2020-10-15 00:49:02 -07:00
Khaled Hosny
fa771a7f85 [tests] Fix memory leak in test 
To make valgrind bot happy.
 2020-10-11 13:15:39 -07:00
David Corbett
1d53268dfe Fix two-way mapping of "man" and 'MNK ' 2020-10-11 11:38:40 -07:00
Behdad Esfahbod
540d2cdddb [tests/buffer] Revert unintended whitespace changes 
From 9e5538d6a3d6f1ffbee7fad3c821621f17d61494

Tried squashing into, but too much merge conflict.
 2020-10-09 22:27:55 -06:00
Behdad Esfahbod
04658ec48f [tests/buffer] Update tests for previous commit 2020-10-09 22:27:55 -06:00
Simon Cozens
7c0bc0bb92 Serialize invalid buffer to !! (text) or [] (json) 
There is no generic deserialize - you have to choose glyphs or unicode - so there is no way to deserialize this buffer.
 2020-10-09 22:27:55 -06:00
Simon Cozens
150f391438 Prohibit mixed glyphs/unicode buffers in deserialization 2020-10-09 22:27:55 -06:00
Simon Cozens
3d3c87e7e7 Put the flags back in and serialize clusters. 
Note that now JSON glyph buffers and Unicode buffers look very similar, except for the g/u property difference.
 2020-10-09 22:27:55 -06:00
Simon Cozens
432a05b2af (Simple) tests for Unicode serialization/deserialization 2020-10-09 22:27:55 -06:00
Garret Rieger
be33704c00 Add gpos 5 tests to meson build file. 2020-10-09 16:46:46 -07:00
Qunxin Liu
3a0b05faf1 [subset] GPOS 5 MarkToLigature subsetting support 2020-10-01 15:59:16 -07:00
Garret Rieger
010accb3d5 [subset] Add additional test cases for the Amiri tests. 2020-09-28 17:39:09 -07:00
Garret Rieger
3271a7cdaa [subset] Remove redundant langys from Amiri test font. 
FontTools removes these when subsetting but harfbuzz does not yet support redundant langsys removal. So this gets the Amiri tests passing for now.
 2020-09-28 16:46:15 -07:00
Garret Rieger
9fad540245 [subset] check that sub rules in ContextFormat 1 and 2 intersect the glyphs set before recursing during closure lookups. 2020-09-28 13:24:25 -07:00
Garret Rieger
7b77ce0507 [subset] Add subsetting integration test using Amiri. 
Demonstrates a failure in subsetting GPOS 8/GSUB 6.
 2020-09-24 16:35:59 -07:00
Garret Rieger
7a72b20aa2 [subset] Subset GDEF during layout subsetting tests. 2020-09-24 15:58:48 -07:00
ebraminio
1f8b1e7f18
[ENOMEM] Return gracefully if stages isn't initialized correctly (#2639) 
This happens if calls to 'm.lookups[table_index].push ()' has been
silently failed due to lack of memory.

This change just returns gracefully instead issuing the assert.

Fixes https://crbug.com/oss-fuzz/24494
 2020-09-21 11:39:38 +03:30
Garret Rieger
bbbcad0dbb Revert "[ENOMEM] don't perform set process operations if the other set is in an error state." 
This reverts commit f3929abafe.
 2020-09-16 12:23:38 -06:00
Garret Rieger
f3929abafe [ENOMEM] don't perform set process operations if the other set is in an error state. 
Running a process while the other set is in an error state can potentially corrupt this sets map map (for example by overwritting all of the major values with 0).
 2020-09-16 10:36:30 -07:00
Simon Cozens
584d3a43b2
Merge pull request #2681 from khaledhosny/myanmar-liga 
[myanmar] Don’t disable liga feature
 2020-09-16 15:08:50 +01:00
Khaled Hosny
7d64b09765 [myanmar] Don’t disable liga feature 
This seems to have been carried over from the Indic shaper, but
Uniscribe enables it by default.

See https://github.com/harfbuzz/harfbuzz/issues/2213#issuecomment-686062915
 2020-09-12 21:45:19 +02:00
Garret Rieger
8c3d4de796 [subset] Fix integer underflow in ContextFormat2. 2020-09-11 15:52:46 -07:00
David Corbett
91fe20f0f5 Disambiguate OT tags when primary tag is not first 2020-09-08 09:20:00 -04:00
David Corbett
e3db84a9d0 [use] Test CGJ and ZWNJ 2020-09-02 15:51:15 -07:00
Garret Rieger
9825e3dd2e [ENOMEM] fix access to unitialized memory. 
If the serialize() call fails to write the object then we can't safely read varstore_prime fields. Fixes https://oss-fuzz.com/testcase-detail/5137462782066688.
 2020-09-02 11:01:07 -07:00
David Corbett
420a74f772 [USE] Fix assertion failure for joining scripts 2020-08-28 14:11:48 -04:00
ebraminio
1e48225ca3
[ENOMEM] Check whether serialize context isn't in error 2020-08-13 23:22:14 +04:30
Ebrahim Byagowi
6e32145dc9 [meson] Make compatbile with 0.47.0 2020-08-13 18:28:42 +04:30
Garret Rieger
9562239f05 [ENOMEM] check for error in lookup visited set. 2020-08-13 01:43:11 +04:30
Garret Rieger
6f754852c1 [ENOMEM] skip asserts in to_bias if serializer is in an error state. 2020-08-12 11:25:30 +04:30
Ebrahim Byagowi
057769b1a3 [fuzzer] minor 2020-08-12 02:40:55 +04:30
Ebrahim Byagowi
0417938011 [fuzzer] Mark alloc_state as unused 
It is really unused when failing-alloc isn't on.
 2020-08-12 02:40:55 +04:30
Ebrahim Byagowi
5193357832 Revert "Remove autotools build support" 
This reverts commit 01ac32aab2.
 2020-08-11 23:51:59 +04:30
Ebrahim Byagowi
ffe06c8f04 [glyf] Guard all the public APIs against null pool runs 
Fixes https://crbug.com/oss-fuzz/24575 and https://crbug.com/oss-fuzz/24737
 2020-08-08 13:43:49 +04:30
Ebrahim Byagowi
01ac32aab2 Remove autotools build support 2020-08-07 23:28:12 +04:30
Ebrahim Byagowi
679fac87df Skip hb_shape if buffer object is immutable 2020-08-06 23:47:35 +04:30
Ebrahim Byagowi
ec17b62457
[var] Apply variations on empty glyphs 
It was ignoring empty glyphs for no good reason, this fixes it.

Fixes #2618
 2020-08-06 20:16:11 +04:30
Garret Rieger
18ab8029d5 [ENOMEM] check vector status in cmap subsetting. 2020-08-02 00:30:17 +04:30
Garret Rieger
06dbb6acbb [ENOMEM] in GSUB ChainContext subsetting check maps for allocation errors. 2020-08-01 09:21:22 +04:30
Garret Rieger
fb1477795c [ENOMEM] Check result of vector resize in CBDT subsetting. 2020-08-01 09:20:52 +04:30
Ebrahim Byagowi
efd716de3f [cff] Check for scalars array resize result 
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=24504
 2020-07-31 09:27:27 +04:30
Garret Rieger
040ed094ef [ENOMEM] popragate packed/packed_map errors to the serializer. 
Will disable further modifications based on a bad state.
 2020-07-31 08:39:26 +04:30
Garret Rieger
7f358a55f4 [ENOMEM] unchecked resize in CFF2. 2020-07-31 02:04:06 +04:30
Garret Rieger
32f052b033 [ENOMEM] Fix several instances of not checking resize in CFF. 2020-07-31 02:04:06 +04:30
Garret Rieger
15644ee60e [ENOMEM] fix memory leak if allocation fails during pop_pack(). 2020-07-30 04:15:35 +04:30
Garret Rieger
42237adffc [ENOMEM] make serializer modification operations no-ops if it's in an error state. 2020-07-30 03:59:49 +04:30
Garret Rieger
4ba8e3c6fd [ENOMEM] Fix failure to check calloc return. 
Fixes https://oss-fuzz.com/testcase-detail/6246465148813312.
 2020-07-30 00:08:08 +04:30
Garret Rieger
d307c24abf [ENOMEM] check resize() return. 
Fixes https://oss-fuzz.com/testcase-detail/5641892164009984.
 2020-07-30 00:08:08 +04:30
Ebrahim Byagowi
48ad745996 [ENOMEM] Fix buffer's content check logic 
So now rest of shape fuzzer also can be enabled.

Fixes #2571
 2020-07-29 08:09:10 +04:30
Ebrahim Byagowi
c33e8006fd [fuzz] Implement failing allocator 2020-07-29 07:35:34 +04:30
Ebrahim Byagowi
d38d63319b
[tests] minor 2020-07-27 09:19:29 +04:30
Ebrahim Byagowi
322426f8c8 [tests] Use TTFont of fonttools to avoid temp files 2020-07-27 09:12:43 +04:30
Hamidreza Bayat
08fef15818 Use fonttools's python package instead of cli 2020-07-27 09:09:06 +04:30
Ebrahim Byagowi
5c46683ab8
[fuzz] increase shape fuzzer timeout 
as https://circleci.com/gh/harfbuzz/harfbuzz/149203
 2020-07-22 17:23:22 +04:30
Ebrahim Byagowi
945bcd7230
minor 2020-07-15 09:54:32 +04:30
Ebrahim Byagowi
fa0436ddd1
[ENOMEM][fuzzer/subset] early return if the result is null 
I don't see _or_fail APIs idiomatic for the project but since it is there, let's have this
 2020-07-15 09:52:40 +04:30
Ebrahim Byagowi
11d583a9ea
[aat] Consume glyph insertion from buffer's max_ops (#2223) 
Glyph insertion is an expensive operation and we like to have it limited
based on buffer's input size which is handled by buffer's max_ops.

clusterfuzz-testcase-minimized-harfbuzz_fuzzer-5754958982021120:

Before the change: 0.67s user 0.00s system 99% cpu 0.674 total
 After the change: 0.02s user 0.00s system 98% cpu 0.024 total

Which takes much longer on valgrind and tsan bots.
 2020-07-13 18:53:06 -07:00
Ebrahim Byagowi
cd6f62d960
[meson] Raise timeout value of subset fuzzer testcases 
happens when tsan is enabled
 2020-07-12 23:05:11 +04:30
Ebrahim Byagowi
e4f9969108 [ci] migrate to meson 
two bots, one bot here (distcheck) and one in travis still run autotools and
won't be removed till we decide about autotools
 2020-07-08 19:18:31 +04:30
Ebrahim Byagowi
e04050e3b8
[meson] split fuzzer_ldflags before use 2020-07-08 01:06:30 +04:30
Ebrahim Byagowi
c5def34730 [meson] don't underscorify fuzzers names 2020-07-06 23:51:52 +04:30
Ebrahim Byagowi
d608f2ac85 [meson] Add fuzzer_ldflags 
As ots, https://github.com/khaledhosny/ots/commit/4d37b9b
 2020-07-06 23:51:52 +04:30
Ebrahim Byagowi
694a0c6bbc [meson] Always add icu deps 2020-07-06 22:19:59 +04:30
Ebrahim Byagowi
ba810ce83d [tests] Replace space with colon in batch mode 2020-07-06 13:53:19 +04:30
Ebrahim Byagowi
2013babcbf
[tests] Use HAVE_FREETYPE itself instead NO_FT_FUNCS 2020-07-06 11:57:45 +04:30
jfkthame
1e6027e29c
[aat] Correct array indexing when looking up actions in KerxSubTableFormat4 (#2539) 
* [aat] Correct array indexing when looking up actions in KerxSubTableFormat4.

- For action_type 0 and 1, there are 2 values per action record; for action_type 2, there are 4. So we need to account for these factors when indexing into the ankrData array.

Fixes https://github.com/harfbuzz/harfbuzz/issues/2531.
 2020-07-05 22:44:10 +01:00
Ebrahim Byagowi
aa732e454a
[tests] minor, ligcarets is fetched from gdef not gsub 2020-07-06 00:10:16 +04:30
Ebrahim Byagowi
122a2897e4 [aat] Remove lcar support 
Very low use, only two distinct font files, Apple Chancery.ttf and Hoefler Text.ttc
have it so it really doesn't worth the size addition and so, but one may argue that
whole ligature caret is low use but guess we better to encourage GDEF one anyway.
 2020-07-06 00:05:36 +04:30
Ebrahim Byagowi
a3b9b94b63
[style] Remove fdsc support (#2541) 
It isn't exposed yet and low use between Apple fonts,
32 fdsc table vs 767 OS/2 tables, even Apple doesn't
support it anymore per Ned.
 2020-07-06 00:05:21 +04:30
Ebrahim Byagowi
a470b0b205 Minor, disable strict-aliasing warning in set fuzzer 
../test/fuzzing/hb-set-fuzzer.cc: In function ‘int LLVMFuzzerTestOneInput(const uint8_t*, size_t)’:
../test/fuzzing/hb-set-fuzzer.cc:38:82: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
   38 |   const instructions_t &instructions = reinterpret_cast<const instructions_t &> (data);
      |

And it is already disabled at project level so let's disable it here also.
 2020-07-05 10:49:10 +04:30
Ebrahim Byagowi
4db1b4f1a2 [tests] rename no_ft_funcs to NO_FT_FUNCS 2020-07-04 16:21:21 +04:30
Ebrahim Byagowi
a07672d353 [py] minor, replace os.environ.get with os.getenv 2020-07-04 16:16:15 +04:30
Ebrahim Byagowi
43e3ab019c [tests] make tests work when ft isn't present 2020-07-04 13:56:08 +04:30
Ebrahim Byagowi
c4b6bad73a [tests] revert da95a8c and use the shared hb-shape process 2020-07-04 13:56:08 +04:30
Ebrahim Byagowi
831b090001 rebase draw test as recent roundf changes 2020-06-28 14:31:21 +04:30
Ebrahim Byagowi
cb7fb3cf4a
Add test for a783840789 2020-06-28 13:41:33 +04:30
Ebrahim Byagowi
47a0fbec31 [meson] Mark longer tests with slow 
So one can skip them easily by `meson test -Cbuild --no-suite slow`
 2020-06-21 08:47:10 +04:30
Ebrahim Byagowi
0881611778 [fuzzer] Make some use for test_font API calls 
Making some use for result of some of the test_font calls to make
sure compilers in fuzzers aren't just optimizing the calls.
 2020-06-20 22:06:11 +04:30
Ebrahim Byagowi
b4f34539c2 [fuzzer] test more of ot-layout APIs 2020-06-20 22:06:11 +04:30
Ebrahim Byagowi
675854b2ba [test] Add one more test for hb_ot_layout_feature_get_characters 2020-06-19 23:27:39 +04:30
Ebrahim Byagowi
1bac85828c [layout] Rename _get_alternates to _get_glyph_alternates 2020-06-18 22:56:07 +04:30
Ebrahim Byagowi
1348a2c865 [layout] hb_ot_layout_lookup_get_alternates, a new API 
An API to retrieve one-to-one alternates from a given GSUB lookup index.
 2020-06-18 09:11:07 +04:30
Khaled Hosny
09dedb1b38 [tests] I’m an idiot 2020-06-18 02:29:12 +02:00
Khaled Hosny
2598855454 [tests] Add test for ReverseChainSingleSubstFormat1 missing substitute 
https://github.com/harfbuzz/harfbuzz/issues/2467
 2020-06-18 02:16:57 +02:00
Ebrahim Byagowi
b86bfe5291 minor, fix lists sorting 2020-06-12 01:42:50 +04:30
Ebrahim Byagowi
4e7cb7e2c4 minor, fix lists sorting 2020-06-12 01:38:16 +04:30
Qunxin Liu
973c47f6c9 [subset] Move 2 experimental public api methods to be private methods in GSUB/GPOS. 
2 methods are: hb_ot_layout_closure_lookups and hb_ot_layout_closure_features
 2020-06-12 01:20:30 +04:30