AuroraMiddleware/harfbuzz
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
4,999 Commits 1 Branch 0 Tags 55 MiB
be9e307a88
Commit Graph

3989 Commits

Author SHA1 Message Date
Behdad Esfahbod
da4866f717 [arabic] Update table to Unicode 10 data 2017-10-02 08:57:06 -04:00
Behdad Esfahbod
1a0a356a0f [indic] Categorize U+0980 BENGALI ANJI as placeholder 
Fixes https://github.com/behdad/harfbuzz/issues/538
 2017-10-02 08:49:23 -04:00
jfkthame
19e77e01bc [shape-plan] Don't look for a cached plan if variation coords are specified. Fixes #549. (#550) 
This is a temporary hack just to avoid incorrect shaping results, pending proper support
for caching shape-plans with variation coordinates.
 2017-10-02 08:08:49 -04:00
mhosken
66128d3cfb Fix missing xscale in rtl graphite unpacking (#541) 
* Fix missing xscale in rtl graphite unpacking

* Oops didn't need to mess with yscale
 2017-09-26 14:29:45 -04:00
Behdad Esfahbod
3ca69c8c32 Use strtod_l() to correctly parse decimal numbers in French & other locales 
Test with, eg.:
$ LC_ALL=fr_FR.utf-8 ./hb-view NotoSansArabic-VF.ttf بهداد --variations wght=1.2
 2017-09-14 20:50:35 -04:00
Behdad Esfahbod
d03f11f246 Fix buffer_diff for empty buffers 
If buffers are empty, content type should be ignored.

This fixes last of the failing tests: fuzzed.tests.  Green again!
 2017-09-04 20:14:13 -07:00
Behdad Esfahbod
7cc348041d [unsafe-to-break] Fix unsafe-to-break for cluster-level=1 
Fixes tests/shaping/tests/cluster.tests
 2017-09-04 20:06:21 -07:00
Behdad Esfahbod
06cb162cd7 [indic] Treat Consonant_With_Stacker as consonant 
Fixes https://github.com/behdad/harfbuzz/issues/528
"Kannada JIHVAMULIYA and UPADHMANIYA insert dotted circles"
 2017-09-01 10:34:56 -07:00
Behdad Esfahbod
c449d2d8c9 [unsafe-to-break] Mark during fraction-slash formation 
Fixes tests/automatic-fractions.tests
 2017-08-30 17:28:22 -07:00
Behdad Esfahbod
099472e08b hb_buffer_diff() tweak 
I like to have a mode where CONTAINS_NOTDEF and CONTAINS_DOTTEDCIRCLE are not
returned.  Abused a value of -1 for that.  hb-shape now uses it.  Fixes two
of the six tests failing with --verify in test/shaping/run-tests.sh.
 2017-08-30 16:45:06 -07:00
Behdad Esfahbod
224d20e4e1 [docs] Minor 2017-08-23 14:49:10 -07:00
Behdad Esfahbod
b2dd0c1c32 Add hb_glyph_info_get_glyph_flags() 
New API.
 2017-08-23 13:12:54 -07:00
Behdad Esfahbod
3e8f4f1452 Rename HB_BUFFER_DIFF_FLAG_MASK_MISMATCH to HB_BUFFER_DIFF_FLAG_GLYPH_FLAGS_MISMATCH 2017-08-22 17:56:25 -07:00
Behdad Esfahbod
8820ba29df Fix warning about "may be used uninitialized" 2017-08-15 17:12:21 -07:00
Emil A Eklund (eae)
91770e1c56 Fix signed/unsigned warning (#522) 
Change hb_buffer_diff to explicitly cast result of abs to unsigned when
comparing with position_fuzz to avoid unsafe signed/unsigned comparions
warnings on windows.
 2017-08-15 16:25:18 -07:00
Behdad Esfahbod
587f15ece3 Minor 2017-08-14 15:23:10 -07:00
Behdad Esfahbod
338e61ad1b Fix typo 2017-08-14 12:36:38 -07:00
Jonathan Kew
331d66c7fe Add function to compare two buffers 
Based on patch from Jonathan Kew.

Needs more cleaning up and documentation.

New API:
hb_buffer_diff_flags_t
hb_buffer_diff()
 2017-08-14 11:44:12 -07:00
Behdad Esfahbod
219af509ef [graphite2] Fix warning 2017-08-13 15:10:26 -07:00
Behdad Esfahbod
239119a631 [unsafe-to-break] Mark all positions as unsafe in alternative shapers 2017-08-13 15:08:34 -07:00
Behdad Esfahbod
05fabbd03e [unsafe-to-break] Towards verifying unsafe-to-break in --verify 
We break and shape fragments and reconstruct shape result from them.
Remains to compare to original buffer.  Going to add some buffer
comparison API and use here, instead of open-coding.
 2017-08-11 20:00:55 -07:00
Behdad Esfahbod
6ce25f57c6 Fix hb_buffer_append() 
Ouch!
 2017-08-11 19:31:05 -07:00
Behdad Esfahbod
1c17c2bde5 [unsafe-to-break] Copy flag to all glyphs in a cluster 
Makes consumption easier.
 2017-08-11 19:06:07 -07:00
Behdad Esfahbod
ec104e5912 [unsafe-to-break] Mark unsafe is cluster merging is disabled 
We were relying on cluster merges not requiring unsafe flagging because
they get merged.  If cluster level requests no merging, then we flag
unsafe when merge would have happened.
 2017-08-11 18:24:27 -07:00
Behdad Esfahbod
39a9749430 New API: hb_buffer_append() 2017-08-11 15:52:06 -07:00
Behdad Esfahbod
14a639ea59 [unsafe-to-break] Fix Use-of-uninitialized-value in unsafe_to_break_set_mask 
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=3011
 2017-08-11 11:30:39 -07:00
Behdad Esfahbod
e43aad5552 [unsafe-to-break] Flag in Thai PUA shaping 2017-08-10 20:54:15 -07:00
Behdad Esfahbod
eae009602b [unsafe-to-break] Flag in Hangul shaper 2017-08-10 20:50:48 -07:00
Behdad Esfahbod
b65aa1cd47 [unsafe-to-break] Flag during mark attachment 2017-08-10 20:32:02 -07:00
Behdad Esfahbod
882ebdadd6 [unsafe-to-break] Flag during cursive positioning 2017-08-10 20:23:17 -07:00
Behdad Esfahbod
2d158ca376 [unsafe-to-break] Flag during kerning 2017-08-10 20:20:30 -07:00
Behdad Esfahbod
a7c4972cce [unsafe-to-break] Flag during fallback positioning 2017-08-10 20:16:15 -07:00
Behdad Esfahbod
e2a2b5b229 [unsafe-to-break] Be careful with flag propagation when merging clusters 2017-08-10 20:11:35 -07:00
Behdad Esfahbod
f2868c2008 Set mask to 0, instead of 1, by default 
This shouldn't matter.
 2017-08-10 20:10:53 -07:00
Behdad Esfahbod
9e005c5d86 [unsafe-to-break] Mark Indic-like clusters as unsafe-to-break 2017-08-10 20:10:53 -07:00
Behdad Esfahbod
5287ccc935 [unsafe-to-break] Allocate public bits from 0 2017-08-10 15:02:34 -07:00
Behdad Esfahbod
91ce0c45d6 [safe-to-break] Fix logic when there is no out-buffer 2017-08-10 15:02:34 -07:00
Behdad Esfahbod
a043c99f77 [unsafe-to-break] Simplify logic 
Always use the algorithm for non-monotone case.  It's more robust.
 2017-08-10 15:02:34 -07:00
Behdad Esfahbod
40bd7e9a1c [unsafe-to-break] Add UNSAFE_TO_BREAK flag 
Not all shapers code is updated to set this properly.
GSUB and Arabic shaper are updated.
GPOS and other shapers are NOT.

Fixes https://github.com/behdad/harfbuzz/issues/224
 2017-08-10 15:02:28 -07:00
Behdad Esfahbod
ac8c4e56d8 [ft] Fix theoretical leak 2017-08-09 22:05:08 -07:00
Behdad Esfahbod
5a33057576 Treat HAMZA ABOVE similar to SHADD for sorting purposes 
Part of https://github.com/behdad/harfbuzz/issues/509
 2017-08-09 17:23:28 -07:00
Behdad Esfahbod
68af14d5cc Protect against div-by-zero in CBDT extent code 
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1452#c5

CC https://github.com/behdad/harfbuzz/issues/139
 2017-08-09 17:09:21 -07:00
Behdad Esfahbod
5dc30451b8 Two fixes to avar mapping 
1. Handle segment with two entries correctly,

2. Fix rounding math.  Ouch!

Fixes https://github.com/behdad/harfbuzz/issues/521
 2017-08-07 21:37:07 -07:00
Behdad Esfahbod
dc2c418e39 [check-defs/symbols.sh] Drop empty-symbol lines 
Fixes https://github.com/behdad/harfbuzz/issues/510
 2017-08-03 12:34:15 +01:00
Ebrahim Byagowi
65f64d1400 Unbreak arm-none-eabi build again (#514) 2017-07-19 02:42:53 +04:30
Behdad Esfahbod
c1432bce3c [arabic] Adjust feature order again 
Fixes https://github.com/behdad/harfbuzz/issues/505
 2017-07-14 17:35:17 +01:00
Cosimo Lupo
9813be3d12 [coretext] Allow to disable kern (#508) 
* Minor

* [coretext] Fix leak

* [coretext] Do not reset num_features

* [coretext] allow to disable kern; re-enabling doesn't seem to be working
 2017-07-14 17:11:46 +01:00
Behdad Esfahbod
9dd29c681e [use] Allow up to two medial-below letters 
Fixes https://github.com/behdad/harfbuzz/issues/376
 2017-07-14 17:01:27 +01:00
Behdad Esfahbod
216b003c91 [use] Fix shaping of U+AA29 CHAM VOWEL SIGN AA 
Part of https://github.com/behdad/harfbuzz/issues/376
Also see https://github.com/roozbehp/unicode-data/issues/6

Test added, using NotoSansCham built from Noto Phase III sources.
 2017-07-14 16:38:51 +01:00
Behdad Esfahbod
f1cd7ca893 [indic] Add github URL 2017-07-14 15:59:40 +01:00
Behdad Esfahbod
3cc84f45b9 [indic] Fix https://github.com/behdad/harfbuzz/issues/478 2017-07-14 15:50:22 +01:00
Behdad Esfahbod
e359a4b8f5 [indic] Disable automatic ZWNJ handling for Indic features 
Fixes https://github.com/behdad/harfbuzz/issues/294

Also fixes a bunch of other Indic issues.  Test results after:

BENGALI: 353725 out of 354188 tests passed. 463 failed (0.130722%)
DEVANAGARI: 707307 out of 707394 tests passed. 87 failed (0.0122987%)
GUJARATI: 366355 out of 366457 tests passed. 102 failed (0.0278341%)
GURMUKHI: 60732 out of 60747 tests passed. 15 failed (0.0246926%)
KANNADA: 951201 out of 951913 tests passed. 712 failed (0.0747968%)
KHMER: 299071 out of 299124 tests passed. 53 failed (0.0177184%)
MALAYALAM: 1048136 out of 1048334 tests passed. 198 failed (0.0188871%)
ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%)
SINHALA: 271662 out of 271847 tests passed. 185 failed (0.068053%)
TAMIL: 1091754 out of 1091754 tests passed. 0 failed (0%)
TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%)

Before:

BENGALI: 353725 out of 354188 tests passed. 463 failed (0.130722%)
DEVANAGARI: 707307 out of 707394 tests passed. 87 failed (0.0122987%)
GUJARATI: 366349 out of 366457 tests passed. 108 failed (0.0294714%)
GURMUKHI: 60732 out of 60747 tests passed. 15 failed (0.0246926%)
KANNADA: 951190 out of 951913 tests passed. 723 failed (0.0759523%)
KHMER: 299070 out of 299124 tests passed. 54 failed (0.0180527%)
MALAYALAM: 1048136 out of 1048334 tests passed. 198 failed (0.0188871%)
ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%)
SINHALA: 271662 out of 271847 tests passed. 185 failed (0.068053%)
TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%)
TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%)
 2017-07-14 14:22:52 +01:00
Behdad Esfahbod
cdf1fd0627 [indic] Add infrastructure to disable ZWNJ-skipping in context-matching 
Not used yet.
 2017-07-14 12:43:34 +01:00
Dominik Schlösser
4e21ec5469 Fix for reordering of Tibetan vowel u (#443) 
* Undone change for Tibetan vowel u

* removed comment on reordering that became invalid with roll-back

* Support for Dzongkha contractions with multiple vowel-signs

* Removed non-functional and unnecessary defines for HB_MODIFIED_COMBINING_CLASS_CCC138,140
 2017-07-14 12:14:23 +01:00
Ebrahim Byagowi
3b0e47ca00 Fix arm-none-eabi build (fixes #451) (#496) 2017-06-19 14:47:09 +04:30
Ebrahim Byagowi
76c4873e8c Support branch prediction helpers on clang compiles (#491) 2017-06-02 13:23:10 -04:00
Behdad Esfahbod
7dba30639a Handle allocation failure in hb-language code 2017-06-01 11:44:42 -04:00
Sebastian Rasmussen
92e2c4baaf Avoid using strdup inside library. (#488) 
If an application provides a malloc replacement through
hb_malloc_impl() it is important that it is used to allocate
everything, but the use of strdup() circumvents this and
causes system malloc() to be called instead. This pairs
badly with the custom hb_free_impl() being called later.
 2017-05-29 10:53:30 -07:00
Khaled Hosny
06cfe3f736 Do not skip TAG characters in glyph substitution (#487) 
Hide them like Mongolian Free Variation Selectors instead.

Fixes https://github.com/behdad/harfbuzz/issues/463
 2017-05-17 11:32:47 -07:00
Behdad Esfahbod
1817221620 Minor 2017-05-16 14:26:28 -07:00
mhosken
74b99ef224 Fix graphite2 rtl conversion (#475) 2017-04-20 11:13:22 -07:00
Chris Peterson
aacca37590 Fix clang -Wcomma warnings (#471) (#472) 
clang's new -Wcomma compiler option warns about possible misuse of the
comma operator such as between two statements.

hb-common.cc:190:9 [-Wcomma] possible misuse of comma operator here
hb-ot-layout-gsubgpos-private.hh:345:30 [-Wcomma] possible misuse of
comma operator here
hb-shape-plan.cc:438:26 [-Wcomma] possible misuse of comma operator here
 2017-04-17 23:25:24 -07:00
William Hua
5ecf96e3a2 Use absolute paths of ragel generated headers (#467) 
https://github.com/behdad/harfbuzz/issues/455
 2017-04-16 22:33:42 -07:00
jfkthame
c04c1fe86e Blacklist GDEF table in additional Tahoma versions. (#459) 
There are more broken versions of Tahoma out there on various Windows releases,
so we need to add them to our blacklist to avoid broken rendering.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1279925 for details.
 2017-04-11 14:29:13 -07:00
ebraminio
adfd4ae1cf [cmake] Improve third party libraries support (#461) 2017-04-11 23:18:18 +04:30
Behdad Esfahbod
a4471d0c2c Move list of ragel sources to Makefile.sources as well 2017-04-05 15:42:11 +02:00
ebraminio
d2acaf6d72 Split ragel generated files lists and remove hardcoded rl files lists (#453) 2017-04-05 11:21:23 +02:00
jfkthame
740fdbcd0e avoid UBSan warning in get_stage_lookups (#450) 
See https://bugzilla.mozilla.org/show_bug.cgi?id=1336600
 2017-04-03 13:22:39 +02:00
Behdad Esfahbod
edcf6344bc Blacklist more versions of Padauk 
Patch from Phil Race.
 2017-03-24 10:24:52 -07:00
Khaled Hosny
91570a1eeb Just always use strtod here 2017-03-22 23:07:20 +02:00
Chun-wei Fan
539571c1a9 src/hb-common.cc: Fix build on older Visual Studio 
Visual Studio only supported strtof() from Visual Studio 2013 onwards, so
use strtod() instead to do the operation, which should do the same thing,
sans going to a double, not a float.
 2017-03-22 23:03:49 +02:00
Behdad Esfahbod
47e7a1800f Revert "Fix Context lookup application when moving back after a glyph delete" 
This reverts commit b9b005f3a4.

This introduced invalid access cases. Revert until I fix correctly.
 2017-03-10 13:23:02 -08:00
Behdad Esfahbod
3c080a7a0a Fix buffer serialize of empty buffer 
Ouch!
 2017-03-07 18:13:28 -08:00
Behdad Esfahbod
9ac9af725c Add TODO item 2017-03-05 13:51:01 -08:00
Behdad Esfahbod
5aec2fb8d0 Remove TODO item that is not going to happen 2017-03-02 11:46:33 -08:00
Behdad Esfahbod
b9b005f3a4 Fix Context lookup application when moving back after a glyph delete 
This was broken forever, since days that we did not allow moving
tape backwards. Works now. Reported by Doug Felt.
 2017-03-01 14:27:23 -08:00
Behdad Esfahbod
85630996b8 Fix buffer-overrun with Bengali reph positioning code 
This has no security implications whatsoever since we always keep
and extra element at the end of buffer, just in case.

Discovered by oss-fuzz
CC https://github.com/behdad/harfbuzz/issues/139
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=660
 2017-02-25 13:32:20 -08:00
Dominik Röttsches
a657f23ca3 Blacklist another instance of Padauk (#419) 
In https://crbug.com/681813 another instance of Padauk was identified
triggering collapsed glyphs. Blacklist this version by patching
hb-ot-layout.cc to print out gdef, gsub, and gpos table length, then
adding those to the list of blacklisted versions.
 2017-02-20 13:52:07 -06:00
jfkthame
44f7d6ecde Guard against underflow when adjusting length (#421) 
* Guard against underflow when adjusting length

With the fuzz-testcase in mozilla bug 1295299, we end up with a recursed lookup that removes 3 items, when `match_positions[idx]` is 0, which results in (unsigned) `end` wrapping to a huge value.

Making `end` a signed int is probably the simplest route to a fix.

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1295299.

* Add testcase for #421.
 2017-02-16 19:03:24 -08:00
jfkthame
45766b673f [indic] Add support for Grantha marks that may be used in Tamil to th… (#401) 
* [indic] Add support for Grantha marks that may be used in Tamil to the Indic table.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1331339.

Testcase: U+0BA4,U+0BC6,U+1133c,U+0BAA,U+1133c,U+0BC6,U+1133c

* [indic] Add test for Grantha nukta that is allowed in Tamil by ScriptExtensions.txt
 2017-02-16 09:40:21 -08:00
Behdad Esfahbod
d4bb52b9fd Unbreak hb-coretext build 2017-02-09 14:13:25 -08:00
Behdad Esfahbod
c8dfed8e1e Merge pull request #357 from khaledhosny/graphite-scale 
[graphite] Fix shaping with varying font sizes
 2017-02-08 14:36:18 -08:00
Behdad Esfahbod
7c47474f20 Set LC_ALL instead of LANG when creating harfbuzz.def 
Hopefully fixes Travis faliure?
https://github.com/behdad/harfbuzz/pull/413#issuecomment-278481882
https://travis-ci.org/khaledhosny/harfbuzz/jobs/199785332#L1065
 2017-02-08 14:33:28 -08:00
Philip Withnall
ffde3c9f9e hb-font: Fix a potentially undefined use of memcmp() (#413) 
While it’s fine to call memcmp(x, 0, 0) in practice, the C99 standard
explicitly says that this is not allowed: even if the length is zero,
the pointer arguments must be valid.

http://stackoverflow.com/a/16363034

Coverity ID: 141178

Signed-off-by: Philip Withnall <withnall@endlessm.com>
 2017-02-08 13:56:57 -08:00
Behdad Esfahbod
73c6dcbb45 Silence Coverity warning 
Fixes https://github.com/behdad/harfbuzz/issues/408
 2017-02-07 16:53:21 -08:00
Behdad Esfahbod
466b3e58bd Shuffle things around a bit 2017-02-03 16:57:15 -08:00
Behdad Esfahbod
fc8189b639 Minor 2017-02-03 16:17:08 -08:00
Behdad Esfahbod
d3d3691806 Add dirty-state tracking to hb_face_t 2017-02-03 15:42:03 -08:00
Behdad Esfahbod
2171f48b4b Add dirty-state tracking to hb_font_t 2017-02-03 10:58:09 -08:00
Behdad Esfahbod
95808bad2c Add new API hb_font_set_face() 
For completeness.
 2017-02-03 10:39:40 -08:00
jfkthame
4ec19319ab Add Win10 Anniversary Update version of Tahoma to GDEF blacklist. (#412) 2017-02-02 10:48:23 -08:00
Behdad Esfahbod
1dd630a7f2 Minor 
Fixes https://github.com/behdad/harfbuzz/issues/411
 2017-02-01 11:57:21 -08:00
Behdad Esfahbod
e888f642db Route Adlam through Arabic shaper 
Fixes joined Adlam rendering.

Fixes https://github.com/googlei18n/noto-fonts/issues/828
 2017-01-26 14:50:14 -08:00
jfkthame
72c754873c Add Win7 version of himalaya.ttf to the GDEF table blacklist. (#407) 2017-01-26 14:35:41 -08:00
Behdad Esfahbod
22af28a3f1 [var] Implement MVAR table 
Unhooked. Untested.
 2017-01-23 23:42:53 -08:00
Behdad Esfahbod
67a191164d [var] Whitespace 2017-01-23 23:21:30 -08:00
Behdad Esfahbod
79e8e27ffd [var] Hook up advance variations to hb-ot-font 
Yay, works!
 2017-01-23 17:57:27 -08:00
Behdad Esfahbod
6074340371 [var] Fix bug in HVAR/VVAR impl 2017-01-23 17:55:16 -08:00
Behdad Esfahbod
bd3b11d926 [var] Prepare for hooking up advance variations to hb-ot-font 2017-01-23 17:37:19 -08:00
Behdad Esfahbod
a4fca9f005 [var] Implement DeltaSetIndexMap and advance delta fetching 
Not hooked up to hb-ot-font yet.
 2017-01-23 12:25:40 -08:00
Behdad Esfahbod
7b399f73ef [var] Start adding HVAR/VVAR 2017-01-23 11:41:43 -08:00
Behdad Esfahbod
b732c53eb5 Add LArrayOf<> 2017-01-22 20:31:53 -08:00
Behdad Esfahbod
5e156fa5ed Add LOffsetTo<> 2017-01-22 20:28:56 -08:00
Behdad Esfahbod
d6bdbbca30 [var] Remove HB_OT_TAG_fvar/avar 
We're not going to define public macros for tags for tables.
There's little use to those and they are implementation detail.
 2017-01-22 20:16:51 -08:00
Behdad Esfahbod
a11d9a0466 Minor 2017-01-22 20:11:57 -08:00
Behdad Esfahbod
7a860f656e [var] Add macros for standard axes 2017-01-22 19:52:09 -08:00
Behdad Esfahbod
a484e237b1 [var] Implement 'avar' table mapping 
Untested!
 2017-01-22 19:41:33 -08:00
Behdad Esfahbod
5ec96d30ca [var] Adjust API in prep for 'avar' implementation 
The 'avar' table does not allow random access to axis maps,
so change API to avoid quadratic-time implementation.

Removed -hb_ot_var_normalize_axis_value(), added
+hb_ot_var_normalize_variations() and
+hb_ot_var_normalize_coords() instead.
 2017-01-22 18:52:00 -08:00
Behdad Esfahbod
8a577aaa0d [var] Stub implementation of avar table 2017-01-22 18:22:40 -08:00
Behdad Esfahbod
7647a05a0b Minor 2017-01-22 17:47:49 -08:00
Behdad Esfahbod
d2f249e745 Stub out doc comments for new symbols 2017-01-22 17:42:33 -08:00
Behdad Esfahbod
5dfd341f51 Minor 2017-01-22 16:55:40 -08:00
Behdad Esfahbod
825e40407d [hb-ft] Remove use of variable-length array 
Hopefully also fixes build failure on msvc.
 2017-01-22 16:41:45 -08:00
Behdad Esfahbod
47ee34e847 [var] Hook up variations to FreeType face 
hb-view correctly renders variations with ft font-funcs now.
hb-ot-font needs HVAR implementation.
 2017-01-21 18:10:08 -08:00
Behdad Esfahbod
bb1e19268f [var] Rename var_coord to variation 
Looks much better.
 2017-01-21 17:42:50 -08:00
Behdad Esfahbod
64fe92bf2d [var] Remove use of variable-length arrays 2017-01-21 15:36:35 -08:00
Behdad Esfahbod
2491134b38 [var] Add hb_font_set_var_coords() 2017-01-21 15:21:50 -08:00
Behdad Esfahbod
113393efec Remove a few unused includes 2017-01-21 15:12:03 -08:00
Behdad Esfahbod
2d40923ca9 Minor 2017-01-21 15:06:15 -08:00
Behdad Esfahbod
8b2a580470 [var] Add hb_font_set_var_coords_design() 2017-01-21 15:05:00 -08:00
Behdad Esfahbod
0dcc7b49a8 [var] Minor lifecycle adjustment 2017-01-21 14:50:22 -08:00
Behdad Esfahbod
bf0d3a665b [var] Add hb_font_get_var_coords_normalized() 2017-01-21 14:48:46 -08:00
Behdad Esfahbod
b3c0714b4b [var] Add hb_var_coord_t and parsing routines 2017-01-20 20:30:03 -08:00
Behdad Esfahbod
72364103bc Move code around 2017-01-20 20:16:53 -08:00
Behdad Esfahbod
785982bf83 [var] Flesh out some more 2017-01-20 20:05:45 -08:00
Behdad Esfahbod
422c0c36c8 [var] Flesh out a bit 2017-01-20 19:14:54 -08:00
Behdad Esfahbod
b8376b1090 Minor 2017-01-20 18:19:28 -08:00
Behdad Esfahbod
f2e73d37e7 [var] Remove over-optimization 2017-01-20 17:42:18 -08:00
Behdad Esfahbod
469926cc45 [var] Change double to float in API 2017-01-20 17:40:46 -08:00
Behdad Esfahbod
55d42fd667 Start adding hb-ot-var.h and implementation 
Supports enumerating variation axes, normalizing values, etc.
 2017-01-19 19:35:48 -08:00
Behdad Esfahbod
272b511532 Minor 2017-01-19 19:33:07 -08:00
Khaled Hosny
2452543fdd [ot] Fix automatic fraction for RTL scripts (#405) 
The numbers for right-to-left scripts are processed also from right to
left, so the order of applying “numr” and “dnom” features should be
reversed in such case.

Fixes https://github.com/behdad/harfbuzz/issues/395
 2017-01-18 12:48:13 -08:00
Sascha Brawer
1337428e4f Update language tags to OpenType 1.8.1 (#403) 
Resolves https://github.com/behdad/harfbuzz/issues/324
 2017-01-18 04:51:02 -08:00
Behdad Esfahbod
784d1180de Fix build with clang 2017-01-11 11:58:13 -08:00
Behdad Esfahbod
1f810daf16 Port math table to hb_lazy_table_loader_t 2017-01-09 23:50:56 -08:00
Behdad Esfahbod
ebbcc11122 Add hb_lazy_table_loader_t 2017-01-09 22:47:47 -08:00
Behdad Esfahbod
1af9d924a4 Move lazy-loader to more generic place 2017-01-09 22:22:37 -08:00
Behdad Esfahbod
ac274331c2 In lazy-loading, remember allocation failure 2017-01-09 22:20:38 -08:00
Behdad Esfahbod
29fb0cb727 Minor 2017-01-09 21:18:55 -08:00
Behdad Esfahbod
93ef684b9b Rename hb-ot-layout-math-table.hh to hb-ot-math-table.hh 2017-01-09 21:11:00 -08:00
Behdad Esfahbod
3b5263b0e9 Typo 2017-01-09 15:49:08 -08:00
Behdad Esfahbod
00adf9c8a4 Minor 
Should be enough to get -hangul.cc out of SOURCES in Firefox build:
https://dxr.mozilla.org/mozilla-central/source/gfx/harfbuzz/src/moz.build

No one else should care!
 2017-01-09 00:00:49 -08:00
Behdad Esfahbod
7cf9952e7f [USE] Remove non-canonical decompositions 
We have had added this in Indic shaper to assist shaping these scripts.
In Universal Shaping Engine however, it is up to font designer to
decompose them.  Hence moving them from Indic shaper to USE was
wrong.

Fixup for f6ba63b2e8

Part of fixing https://github.com/behdad/harfbuzz/issues/387
 2017-01-08 23:55:54 -08:00
Khaled Hosny
b435c7c46a [graphite] Stop creating unused gr_face 
It is unused after previous commit, hb_graphite2_font_get_gr_font()
makes no sense now so deprecating it.
 2017-01-07 01:57:28 +02:00
Khaled Hosny
1b00a3b048 [graphite] Fix shaping with varying font sizes 
Shape using design units and scale the output.

See https://bugs.documentfoundation.org/show_bug.cgi?id=103403#c7
 2017-01-07 01:57:28 +02:00
Behdad Esfahbod
53543f8b3e Ship UCDN and use it by default 
So we are not relying on version of Unicode data in glib...

Fixes https://github.com/behdad/harfbuzz/issues/386
Fixes https://github.com/behdad/harfbuzz/issues/388
 2017-01-05 20:12:32 -08:00
Frédéric Wang
ae00af4a47 Move math-specific code from hb-ot-layout to hb-ot-math #235 (#384) 2017-01-02 23:55:09 -05:00
Behdad Esfahbod
6cff753941 Remove Tibetan decomposition rules from Indic shaper 
The decomposition is very obscure and unlikely to help
any fonts.  Just remove it since Uniscribe probably doesn't
do this either.

Fixes https://github.com/behdad/harfbuzz/issues/382
 2016-12-28 13:47:13 -05:00
Behdad Esfahbod
f6ba63b2e8 Port decompositions from Indic to USE shaper 
Part of https://github.com/behdad/harfbuzz/issues/382
 2016-12-28 13:45:32 -05:00
Behdad Esfahbod
e678b537f7 [indic] Remove Chakma decomposition rule from Indic shaper 
This is now added to USE:
https://github.com/behdad/harfbuzz/pull/383

See:
https://github.com/behdad/harfbuzz/issues/381
https://github.com/behdad/harfbuzz/issues/382
 2016-12-28 13:40:55 -05:00
jfkthame
49ba698124 [use] Special-case Chakma split-vowel decomp in the USE shaper. (#383) 2016-12-28 13:00:51 -05:00
Behdad Esfahbod
c4ca49d55b Revert "[indic] Remove redundant Chakma decomposition rule" 
This reverts commit 805f76fc00.

Need to investigate why having this rule (with the reversed order)
fixes decomposition as reported by punchcutter:
https://github.com/behdad/harfbuzz/issues/381#issuecomment-269237796
 2016-12-26 14:52:08 -05:00
Behdad Esfahbod
805f76fc00 [indic] Remove redundant Chakma decomposition rule 
This was not used BTW since Chakma doesn't go through Indic shaper
anymore.

See:
https://github.com/behdad/harfbuzz/issues/381
https://github.com/behdad/harfbuzz/issues/382
 2016-12-26 14:12:39 -05:00
Behdad Esfahbod
3cc48a46b5 [indix] Comment 2016-12-26 13:16:56 -05:00
nvelinov
7d1c5d8281 Compilation Error for ASSERT_STATIC on Some Compilers (#380) 
* this pointer in type definitions is not interpreted as a constant.
This rule is not enforced strictly by all compilers, but the Green Hills Software compiler will regard this as an error.

* Merging branches for the DEFINE_SIZE_UNION macro
Adding check for the existence of static_size field in the tested member.
 2016-12-23 19:46:37 -06:00
Behdad Esfahbod
e2b878055b Disable OTL processing for Hebrew if GPOS doesn't have Hebrew subtable 
New approach to fix this:
69f9fbc420

Previous approach was reverted as it was too broad.  See context:
https://github.com/behdad/harfbuzz/issues/347#issuecomment-267838368

With U+05E9,U+05B8,U+05C1,U+05DC and Arial Unicode, we now (correctly) disable
GDEF and GPOS, so we get results very close to Uniscribe, but slightly different
since our fallback position logic is not exactly the same:

Before:		[gid1166=3+991|gid1142=0+737|gid5798=0+1434]
After:		[gid1166=3+991|gid1142=0@402,-26+0|gid5798=0+1434]
Uniscribe:	[gid1166=3+991|gid1142=0@348,0+0|gid5798=0+1434]
 2016-12-22 14:43:23 -06:00
Behdad Esfahbod
1a0f4aa6df Revert "Synthesize GDEF glyph class for any glyph that does not have one in GDEF" 
This reverts commit 69f9fbc420.

See https://github.com/behdad/harfbuzz/issues/347#issuecomment-268873401
Fixes https://github.com/behdad/harfbuzz/issues/347
 2016-12-22 14:43:14 -06:00
Behdad Esfahbod
4b4a1b9f23 Fix assert fail with contextual matching 
As discovered by libFuzzer / Chromium fuzzing.

Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=659496
CC https://github.com/behdad/harfbuzz/issues/139
 2016-12-21 23:14:16 -06:00
Behdad Esfahbod
df98ce5fc8 Improve debug output with really deep nesting 2016-12-21 19:27:30 -06:00
Behdad Esfahbod
eab418c5e6 Avoid infinite loop in CoverageFormat2 iteration with bad fonts 
Fixes https://github.com/behdad/harfbuzz/issues/363
 2016-12-21 15:51:28 -06:00
Behdad Esfahbod
7ed71eb347 Protect collect_glyphs() and closure() against malicious DDOS fonts 
Fixes https://github.com/behdad/harfbuzz/issues/363
 2016-12-20 15:01:16 -06:00
Mike Hommey
1c98ff87c7 Support building with older glib versions 
It is desirable to be able to build against older versions of glib.

fd7a245 changed the configure check to require glib > 2.38 for
G_TEST_DIST. Before that, version 2.16 was required, but in fact,
since aafe395, G_PASTE is being used, which was introduced in 2.19.1.
And since 0ef179e2, hb-glib uses GBytes, which were introduced in
2.31.10.

2.19.1 is rather old, but 2.38 is rather new. For Firefox, building
against 2.22 is still supported, although we could probably get away
with bumping that to 2.28. Either way, GBytes is not available.

Arguably, if you build against a glib that doesn't support GBytes,
you're not going to use the hb_glib_blob_create function, so we hide
the function when building against such a glib.

As for G_TEST_DIST, when building against versions of glib that don't
support it, we can fallback to the previous behavior, which, AIUI, was
just making the test not work when building in a separate directory.
 2016-12-18 01:37:07 -06:00
Volker H. Simonis
ad273881c5 Minor fixes to pacify Coverity code scan 
Fixes https://github.com/behdad/harfbuzz/pull/377
 2016-12-18 00:14:06 -06:00
ebraminio
1e1825bf47 [dwrite] Provide an experimental API for justification (#279) 2016-12-17 10:30:40 +03:30
Behdad Esfahbod
219cb29c5d Fix build after rebasing opentype-gx branch on top of MATH table 2016-12-16 19:06:26 -06:00
Behdad Esfahbod
0aedfd59be [GX] Apply 'rvrn' feature before any other feature 2016-12-16 19:06:26 -06:00
Behdad Esfahbod
42c8142531 [GX] Fix build with older FreeType 2016-12-16 19:06:26 -06:00
Sascha Brawer
72873cf522 Call hb_font_set_var_coords_normalized() from FT_Face coords 2016-12-16 19:06:26 -06:00
Behdad Esfahbod
4ebbeb7c50 [GX] Make FeatureVariations actually work 
Yay!!!!
 2016-12-16 19:06:26 -06:00
Behdad Esfahbod
72ada4f0c6 [GX] Hook up feature variations 
Shape-plan caching is not implemented.
 2016-12-16 19:06:26 -06:00
Behdad Esfahbod
ec87ba9ba3 [GX] Add hb_ot_layout_feature_with_variations_get_lookups() 2016-12-16 19:06:26 -06:00
Behdad Esfahbod
30c42b644e [GX] Add hb_ot_layout_table_find_feature_variations() 2016-12-16 19:06:26 -06:00
Behdad Esfahbod
7ceadbe981 Shuffle code around 2016-12-16 19:06:26 -06:00
Behdad Esfahbod
bde5e3959c Move add_lookups from map to map-builder 
In prep for more changes.
 2016-12-16 19:06:26 -06:00
Behdad Esfahbod
26648cebcd [GX] Remove (partial) support for anisotropic variations 
It doesn't always work, not part of FreeType, and we were not going
to expose it in the API anyway.  Can always be added later.
 2016-12-16 19:06:26 -06:00
Behdad Esfahbod
c22176d4ba [GX] Handle setting var coords to NULL 2016-12-16 19:06:26 -06:00
Behdad Esfahbod
59055b5494 [GX] Implement Feature Variations 
Not hooked up to shaper yet.
 2016-12-16 19:06:26 -06:00
Behdad Esfahbod
85ec494434 [GX] Fix another x/y thinko 
Thanks Werner!
 2016-12-16 19:06:26 -06:00
Behdad Esfahbod
cf3de4d8f7 [GX] Rename VarStore to VariationStore 2016-12-16 19:06:26 -06:00
Behdad Esfahbod
1f6ed356e0 [GX] Fix build with some compilers 
Eg. https://ci.appveyor.com/project/behdad/harfbuzz/build/1.0.48/job/o9mnd33kcdeeg30r

hb-open-type-private.hh:103:29: error: static data member 'OT::Device::<anonymous union>::<anonymous struct>::static_size' in unnamed class [-fpermissive]
 2016-12-16 19:06:26 -06:00
Behdad Esfahbod
250bcd6fb6 [GX] Skip tail zero entries when setting variation coordinates 2016-12-16 19:06:26 -06:00
Behdad Esfahbod
1124d2ece5 [GX] Fix thinko 2016-12-16 19:06:26 -06:00
Behdad Esfahbod
ad69e8f07c [GX] Add new API hb_font_set_var_coords_normalized() 
Will probably change.
 2016-12-16 19:06:26 -06:00
Behdad Esfahbod
151d93de8a [GX] Hook up GPOS to Variation Store stored in GDEF 
Untested.
 2016-12-16 19:06:26 -06:00
Behdad Esfahbod
dcfd309533 [GX] Change GDEF API to return varStore 2016-12-16 19:06:26 -06:00
Behdad Esfahbod
49cb87850c [GX] Pass apply-context down to get_anchor() 
Needed to access GDEF for varStore.
 2016-12-16 19:06:26 -06:00
Behdad Esfahbod
f0c3fd8c9a [GX] Add varStore member to GDEF 
Still not hooked up from GPOS.
 2016-12-16 19:06:26 -06:00
Behdad Esfahbod
5c971f8dbc Minor change to GDEF, in prep for new version 2016-12-16 19:06:26 -06:00
Behdad Esfahbod
dc9f229799 [GX] Port variation stuff to Variation Store design 
Not hooked up to GDEF yet.
 2016-12-16 19:06:26 -06:00
Behdad Esfahbod
a7edeb6f02 Make OffsetArrayOf take OffsetType template argument 2016-12-16 19:06:26 -06:00
Behdad Esfahbod
8dddc231cf [GX] Revert "[GX] Add VariationAlternates, to allow conditional lookups in GSUB/GPOS" 
This reverts commit 2859f1c7174d6f7ae5dcf0db5411bc0182b21594.
We are going in a different direction.
 2016-12-16 19:06:26 -06:00
Behdad Esfahbod
bb4d2e6ed5 [GX] Free GX coordinates 2016-12-16 19:06:26 -06:00
Behdad Esfahbod
baa329c6a1 [GX] Add compact VariationDevice implementation 
Add compact format that uses signed bytes instead of shorts.
 2016-12-16 19:06:26 -06:00
Behdad Esfahbod
71b06fd392 [GX] Add VariationAlternates, to allow conditional lookups in GSUB/GPOS 
Not hooked up to runtime yet.
 2016-12-16 19:06:26 -06:00
Behdad Esfahbod
976eeb8e02 [GX] Minor 2016-12-16 19:06:26 -06:00
Behdad Esfahbod
ed8a9067ca [GX] Minor 2016-12-16 19:06:26 -06:00
Behdad Esfahbod
15c5ee6747 [GX] Minor rename 2016-12-16 19:06:26 -06:00
Behdad Esfahbod
4c535a822f [GX] Hookup VariationDevice to Device table implementation 2016-12-16 19:06:26 -06:00
Behdad Esfahbod
a0c2366075 [GX] Break out early if factor is zero 
Also disable sanity-checking of variation records.
 2016-12-16 19:06:26 -06:00
Behdad Esfahbod
ca28670316 [GX] Towards anisotropic interpolation 
Also hookup to ValueRecord and Anchors.
 2016-12-16 19:06:26 -06:00
Behdad Esfahbod
6d9d3c55bb [GX] Add data types for encoding numerical variations 2016-12-16 19:06:26 -06:00
Behdad Esfahbod
e4bfccfb2a [CBDT] Minor 2016-12-04 19:45:46 -08:00
Behdad Esfahbod
b7068af423 [CBDT] Fix thinko! 2016-12-04 19:36:30 -08:00
Behdad Esfahbod
a141d1da9b [CBDT] Implement IndexSubtableFormat3 2016-12-04 19:26:54 -08:00
Behdad Esfahbod
9eda74c92c [cbdt] Move some more code around 2016-12-04 19:12:52 -08:00
Behdad Esfahbod
654f9ab0d8 [cbdt] Fix sign bug 
Was introduced in d495fc5e38
 2016-12-04 18:56:24 -08:00
Behdad Esfahbod
c27d6fcf8d [cbdt] Last of sanitization fixes 
Should be all good now..
 2016-12-02 22:43:05 -08:00
Behdad Esfahbod
d495fc5e38 [cbdt] Clean up some more 
Almost there..
 2016-12-02 21:52:33 -08:00
Behdad Esfahbod
ce09e90e15 [cbdt] More sanitize work 2016-12-02 20:12:57 -08:00
Behdad Esfahbod
70eb2ff682 Check for offset overflows during sanitize 2016-12-02 19:51:23 -08:00
Behdad Esfahbod
4b58c9e326 [cbdt] Start fixing sanitization (or lack thereof) 2016-12-02 19:25:54 -08:00
Behdad Esfahbod
b92ba7bafc [CBDT] Use CHAR instead of int8_t 2016-12-02 15:21:43 -08:00
Behdad Esfahbod
efca7bf97f Rename 'ebdt' to 'cbdt' since we only support the PNG format 2016-12-02 15:11:37 -08:00
Seigo Nonaka
831852594b Introduce get_extent support for color bitmap font. (#351) 
hb_font_get_glyph_extents now works for color bitmap fonts.
Currently only font having index format 1 and image format 17
is supported.
 2016-12-02 17:03:50 -06:00
Behdad Esfahbod
2b117720c0 Use horizontal ascent as fallback vertical origin 2016-10-26 18:12:50 +02:00
Behdad Esfahbod
a7b32f2057 Move code around 2016-10-26 18:08:41 +02:00
Behdad Esfahbod
63635c763d [hb-ot-font] Use ascent+descent as fallback vertical advance 2016-10-26 18:01:24 +02:00
Behdad Esfahbod
9ee23c49a7 Fix vertical glyph origin with hb-ot-font 2016-10-26 18:01:24 +02:00
Behdad Esfahbod
b3b0816d5f Fix vertical font metrics 
Ouch!
 2016-10-26 18:01:20 +02:00
Behdad Esfahbod
0e79ebb3ca [gobject] Update for new MATH structs 2016-10-26 10:32:48 +02:00
Ebrahim Byagowi
bef240b36e [ci] Whitelist more symbols and unbreak mac CI 
Thanks to @khaledhosny, actually this is his work :)
 2016-10-11 17:12:08 +03:30
Behdad Esfahbod
d1c62370a0 Aim math API for 1.3.3 instead of 1.4.0 2016-10-04 14:47:12 -07:00
Khaled Hosny
7adbc5dd62 Fix building math docs (#335) 2016-09-30 04:01:24 -07:00
Behdad Esfahbod
c3e21a6620 [MATH] Fix more docs 2016-09-27 16:51:38 +02:00
Behdad Esfahbod
46cc4a3a2a [MATH] Rename hb_math_*_t types to hb_ot_math_*_t 
With this, I believe MATH table API is not ready to be merged.
 2016-09-27 16:44:22 +02:00
Frédéric Wang
0762b35474 Document API for MathVariants (#330) 2016-09-27 15:28:35 +02:00
Behdad Esfahbod
bc19f7fe20 [MATH] Add HB_OT_MATH_SCRIPT 2016-09-27 10:58:08 +02:00
Behdad Esfahbod
86106c7528 [MATH] Rename all API to hb_ot_math_* 2016-09-26 22:14:29 +02:00
Behdad Esfahbod
1ba767cd4e [MATH] Move API from hb-ot-layout.h to hb-ot-math.h 2016-09-26 21:57:14 +02:00
Behdad Esfahbod
97b72da600 Whitespace 2016-09-26 21:53:25 +02:00
Behdad Esfahbod
559eb56447 [MATH] Wire up get_glyph_assembly() 2016-09-26 21:46:05 +02:00
Behdad Esfahbod
353f455af7 [MATH] Wire up get_glyph_variants() 2016-09-26 21:25:00 +02:00
Behdad Esfahbod
7fe0e28c22 [MATH] Start fleshing out glyph variant API 2016-09-26 17:51:47 +01:00
Behdad Esfahbod
1f3327f210 [MATH] Clean up math variants 2016-09-26 16:10:08 +01:00
Frédéric Wang
51da7a1cd6 MATH table: Add API to access math variants. 2016-09-26 15:18:16 +01:00
Behdad Esfahbod
8d58e3433e [MATH] Fix get_kerning() with negative y-scale 2016-09-26 13:39:58 +01:00
Behdad Esfahbod
94f5df5626 [MATH] Clean up get_kerning() 2016-09-26 13:31:47 +01:00
Behdad Esfahbod
17ff30e9af [MATH] Clean up get_top_accent_attachment() 
Note, the function now returns "half of horizontal advance width"
if top accent attachment for glyph is not explicitly defined.
This is what the spec requires.  Updated tests.
 2016-09-26 12:21:27 +01:00
Behdad Esfahbod
8bcf517fe5 [MATH] Clean up get_italics_correction() 2016-09-26 12:13:14 +01:00
Behdad Esfahbod
06003f71ba [MATH] Clean up a bit more 2016-09-26 12:07:29 +01:00
Behdad Esfahbod
54c0cc38fb [MATH] Clean up get_math_constant implementation 2016-09-26 11:56:40 +01:00
Behdad Esfahbod
8a8cfad9a0 [MATH] Cleanup previous commit a bit 2016-09-26 11:51:07 +01:00
Frédéric Wang
d7182d1296 MATH Table: Add API to access glyph info. 2016-09-26 11:32:25 +01:00
Behdad Esfahbod
6fd2fe418d [MATH] Fixup math constants commit a bit more 2016-09-26 11:24:39 +01:00
Behdad Esfahbod
1a381153a2 [MATH] Fixups for math constants commit 2016-09-26 11:15:59 +01:00
Frédéric Wang
319ff59161 MATH Table: Add API to access math contants. 2016-09-26 10:49:09 +01:00
Behdad Esfahbod
4d3892e9b0 [MATH] Fixups for previous commit 2016-09-26 10:45:58 +01:00
Frédéric Wang
5fbcb992bd MATH Table: Add API to check availability of math data. 2016-09-26 10:27:33 +01:00
Ebrahim Byagowi
fc4e671f31 [coretext] Use intended coretext version check logic (#315) 2016-09-09 11:58:28 -07:00
Khaled Hosny
4867734528 Try to unbreak building on older macOS again (#314) 2016-09-07 18:44:37 -07:00