Commit Graph

6707 Commits

Author SHA1 Message Date
Behdad Esfahbod
3ee96984f4 Fixup atomics from recent change 2018-09-27 17:20:26 -04:00
Behdad Esfahbod
305468708d [cache] Use atomic writes in clear()
To help TSan.
2018-09-27 16:54:23 -04:00
Volker Krause
9e9a36ee65 Fix infinite loop when walking up the directory hierarchy (#1183)
A single find_package(harfbuzz) line in user code resulted in this loop
getting stuck when _harfbuzz_libdir_iter became "/".
2018-09-27 18:03:49 +03:30
Ebrahim Byagowi
0c1d852bc4
Use clang for compiling freetype for tsan bot 2018-09-27 11:53:17 +03:30
Behdad Esfahbod
662f7d7e8b [arabic] Do the joiner-flipping only for rlig feature
See comment.
2018-09-26 18:54:09 -04:00
Behdad Esfahbod
7f30629cdd [ft] Make TSan happy 2018-09-26 16:40:59 -04:00
Behdad Esfahbod
ec743fce2a Add more atomic intrinsics 2018-09-26 16:40:59 -04:00
Behdad Esfahbod
d183b33c1d Rename test 2018-09-26 16:40:59 -04:00
Ebrahim Byagowi
c9c75fe3d9
[ci] Compile freetype on tsan and put sanitizer flags on correct places (#1188) 2018-09-27 00:08:06 +03:30
Ebrahim Byagowi
39da1914b4
Test freetype funcs on test-multithread (#1187) 2018-09-26 23:32:45 +03:30
Ebrahim Byagowi
e88009a93f
Minor, remove the no longer needed comment on test-multithread 2018-09-26 22:53:02 +03:30
Behdad Esfahbod
90a0f9fa0c Make TSan happy with make_immutable() 2018-09-26 15:03:07 -04:00
Behdad Esfahbod
34d5a25953 Fix test-multithread and increase num_threads to 30
What were you thinking? ;)
2018-09-26 15:02:21 -04:00
Ebrahim Byagowi
8bb73dad7f
Add a multithreaded test (#1184) 2018-09-26 20:50:51 +03:30
Behdad Esfahbod
04caf11608 [hb-view] Change subpixel bits from 8 to 6
To match FreeType units, such that FreeType gets correct size from us.
This matters more now that we allow setting --ft-load-flags.
2018-09-26 12:13:47 -04:00
Behdad Esfahbod
824111d484 Fix iOS build
Fixes https://github.com/harfbuzz/harfbuzz/pull/1179
2018-09-25 12:47:48 -04:00
Ebrahim Byagowi
4b4be7701f
[circle] Add an obsessive clang bot (#1178) 2018-09-25 09:24:35 +03:30
Behdad Esfahbod
8282e881b5 Disable msan bot again
Fixes https://github.com/harfbuzz/harfbuzz/issues/1175
2018-09-24 19:43:01 -04:00
Behdad Esfahbod
6c0e7eb6a6 Minor 2018-09-24 19:07:23 -04:00
Behdad Esfahbod
d748dc7664 More iter inits 2018-09-24 18:30:50 -04:00
Behdad Esfahbod
d9867497d0 Minor 2018-09-24 18:11:59 -04:00
Behdad Esfahbod
70136a78cb Remove F_COMBINE
Now I wonder if any bots will be unhappy we calling | in static const initializations...
Or would that cost runtime init?  Our tests don't detect any..
2018-09-24 18:04:17 -04:00
Behdad Esfahbod
f048ead84a Some more 2018-09-24 18:04:17 -04:00
Behdad Esfahbod
1676f608c8 Minor refactoring 2018-09-24 18:04:17 -04:00
Ebrahim Byagowi
1020333960
[circleci] Update sanitizer bots with newer clang and Ubuntu version (#1176) 2018-09-25 01:00:32 +03:30
Behdad Esfahbod
12b8baa765 [msan] Enable again to get a build log, and try to play with suppressions 2018-09-24 17:22:39 -04:00
Behdad Esfahbod
aec0d3cbc9 [ubsan] Re-enable now that it passes locally 2018-09-24 13:12:15 -04:00
Behdad Esfahbod
4839807340 [check-static-inits.sh] Allow some if ubsan is in effect 2018-09-24 13:11:34 -04:00
Behdad Esfahbod
e45ba31dc7 [check-symbols.sh] Allow weak objects "V"
ubsan generates these.
2018-09-24 13:04:48 -04:00
Behdad Esfahbod
d07f3111b4 Link API test programs with C++ linker
Needed to make ubsan work.

Fixes https://github.com/harfbuzz/harfbuzz/issues/1174
2018-09-24 13:01:35 -04:00
Behdad Esfahbod
a96508cfc9 [msan] Add MSAN_OPTIONS=exitcode=42
Default exit value is 77, which causes autotools to "skip" test.
2018-09-24 12:52:42 -04:00
Behdad Esfahbod
45f5aa9790 [circleci] Disable msan and ubsan builds
https://github.com/harfbuzz/harfbuzz/issues/1174
https://github.com/harfbuzz/harfbuzz/issues/1175
2018-09-24 12:43:29 -04:00
Behdad Esfahbod
2d93148a0f Ignore weak symbols in check-symbols.sh
Some clang versions leave a std::round(float) weak symbol around...
2018-09-24 11:52:22 -04:00
Behdad Esfahbod
55bae6825e [docs] A few improvements
If we wrote just this much every day...
2018-09-24 10:43:06 -04:00
Behdad Esfahbod
57fa2c23de Readjust Hebrew composition again 2018-09-24 09:57:52 -04:00
Behdad Esfahbod
7f335390f3 Revert change that would decompose text if GPOS mark feature is available
https://github.com/harfbuzz/harfbuzz/issues/653#issuecomment-423905920
2018-09-24 09:56:18 -04:00
Behdad Esfahbod
a6f4b2f7cd Fix normalization
62d1e0852a (commitcomment-30613091)
2018-09-24 09:54:37 -04:00
Behdad Esfahbod
3583fb03b1 Simplify ZWJ-skipping a bit
Towards disabling ZWJ-skipping in certain GPOS contexts.

Part of https://github.com/flutter/flutter/issues/16886
2018-09-23 22:33:38 -04:00
Behdad Esfahbod
9516cbd3df Reinit skippy iters when auto_zwj / auto_zwnj change
Ouch.  How did we not hit this bug before...
2018-09-23 22:00:34 -04:00
Behdad Esfahbod
62d1e0852a Prefer decomposed form if font has GPOS mark feature
Fixes https://github.com/harfbuzz/harfbuzz/issues/653
2018-09-23 21:32:18 -04:00
Behdad Esfahbod
d7f21777e6 [ot-font] Fix leak
Fixes https://github.com/harfbuzz/harfbuzz/issues/1171

I'm glad we have leak-detector bots now.
2018-09-23 19:12:52 -04:00
Ebrahim Byagowi
ae39a53f55 Add bots with address- and thread-sanitizer 2018-09-23 15:23:29 -07:00
Matt Oliver
24dd6c1a9d src/hb-blob.cc: Fix mmap functionality with UWP. 2018-09-23 07:23:58 -07:00
Khaled Hosny
b7f1bbc2f8 [test] Fix printing subprocess error messages
Decode the string as Python 3 returns bytes string, and also don’t
assume that it ends with a new line.
2018-09-22 17:20:06 +02:00
Ebrahim Byagowi
403019482b
Fix test-subset-* leak issues
See also https://github.com/harfbuzz/harfbuzz/pull/1169
2018-09-22 17:24:03 +03:30
Ebrahim Byagowi
f6ebe1f4dc
Fix test-ot-math leak issue
See also https://github.com/harfbuzz/harfbuzz/pull/1169
2018-09-22 17:05:52 +03:30
Ebrahim Byagowi
669ac81ac5
Fix test-set leak issue
See also https://github.com/harfbuzz/harfbuzz/pull/1169
2018-09-22 16:49:23 +03:30
Ebrahim Byagowi
ef9307fd22
Fix test-font leak issue
See also https://github.com/harfbuzz/harfbuzz/pull/1169
2018-09-22 16:45:31 +03:30
Behdad Esfahbod
5fd8bce945 [morx] Fix mark_set check 2018-09-19 22:34:09 -04:00
Behdad Esfahbod
0739b28169 [aat] Minor 2018-09-19 17:32:21 -04:00