Add helper function zero_malloc for tests
This commit is contained in:
parent
4d2a8eb6ff
commit
0dc5e0d80b
@ -101,12 +101,33 @@ static void hexify(unsigned char *obuf, const unsigned char *ibuf, int len)
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Allocate and zeroize a buffer.
|
||||
*
|
||||
* If the size if zero, a pointer to a zeroized 1-byte buffer is returned.
|
||||
*
|
||||
* For convenience, dies if allocation fails.
|
||||
*/
|
||||
static unsigned char *zero_alloc( size_t len )
|
||||
{
|
||||
void *p;
|
||||
size_t actual_len = len != 0 ? len : 1;
|
||||
|
||||
assert( ( p = polarssl_malloc( actual_len ) ) != NULL );
|
||||
|
||||
memset( p, 0x00, actual_len );
|
||||
|
||||
return( p );
|
||||
}
|
||||
|
||||
/**
|
||||
* Allocate and fill a buffer from hex data.
|
||||
*
|
||||
* The buffer is sized exactly as needed. This allows to detect buffer
|
||||
* overruns (including overreads) when running the test suite under valgrind.
|
||||
*
|
||||
* If the size if zero, a pointer to a zeroized 1-byte buffer is returned.
|
||||
*
|
||||
* For convenience, dies if allocation fails.
|
||||
*/
|
||||
static unsigned char *unhexify_alloc( const char *ibuf, size_t *olen )
|
||||
@ -115,6 +136,9 @@ static unsigned char *unhexify_alloc( const char *ibuf, size_t *olen )
|
||||
|
||||
*olen = strlen(ibuf) / 2;
|
||||
|
||||
if( *olen == 0 )
|
||||
return( zero_alloc( *olen ) );
|
||||
|
||||
assert( ( obuf = polarssl_malloc( *olen ) ) != NULL );
|
||||
|
||||
(void) unhexify( obuf, ibuf );
|
||||
|
@ -59,9 +59,7 @@ void pkcs5_pbes2( int params_tag, char *params_hex, char *pw_hex,
|
||||
data = unhexify_alloc( data_hex, &data_len );
|
||||
pw = unhexify_alloc( pw_hex, &pw_len );
|
||||
ref_out = unhexify_alloc( ref_out_hex, &ref_out_len );
|
||||
my_out = polarssl_malloc( ref_out_len != 0 ? ref_out_len : 1 );
|
||||
TEST_ASSERT( my_out != NULL );
|
||||
memset( my_out, 0, ref_out_len );
|
||||
my_out = zero_alloc( ref_out_len );
|
||||
|
||||
my_ret = pkcs5_pbes2( ¶ms, PKCS5_DECRYPT,
|
||||
pw, pw_len, data, data_len, my_out );
|
||||
|
Loading…
Reference in New Issue
Block a user