AuroraMiddleware/mbedtls
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

test: Always use make clean by itself

Browse Source 
When running make with parallelization, running both "clean" and "lib"
with a single make invocation can lead to each target building in
parallel. It's bad if lib is partially done building something, and then
clean deletes what was built. This can lead to errors later on in the
lib target.

    $ make -j9 clean lib
      CC    aes.c
      CC    aesni.c
      CC    arc4.c
      CC    aria.c
      CC    asn1parse.c
      CC    ./library/error.c
      CC    ./library/version.c
      CC    ./library/version_features.c
      AR    libmbedcrypto.a
    ar: aes.o: No such file or directory
    Makefile:120: recipe for target 'libmbedcrypto.a' failed
    make[2]: *** [libmbedcrypto.a] Error 1
    Makefile:152: recipe for target 'libmbedcrypto.a' failed
    make[1]: *** [libmbedcrypto.a] Error 2
    Makefile:19: recipe for target 'lib' failed
    make: *** [lib] Error 2
    make: *** Waiting for unfinished jobs....

To avoid this sort of trouble, always invoke clean by itself without
other targets throughout the library. Don't run clean in parallel with
other rules. The only place where clean was run in parallel with other
targets was in list-symbols.sh.
This commit is contained in:
Jaeden Amero 2019-05-31 12:26:42 +01:00
parent 2ab5cf658f
commit 3b025ac52b
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tests/scripts/list-symbols.sh
View File

@ -14,12 +14,13 @@ fi
cp include/mbedtls/config.h include/mbedtls/config.h.bak cp include/mbedtls/config.h include/mbedtls/config.h.bak
scripts/config.pl full scripts/config.pl full
make clean
make_ret= make_ret=
CFLAGS=-fno-asynchronous-unwind-tables make clean lib \ CFLAGS=-fno-asynchronous-unwind-tables make lib \
>list-symbols.make.log 2>&1 || >list-symbols.make.log 2>&1 ||
{ {
make_ret=$? make_ret=$?
echo "Build failure: CFLAGS=-fno-asynchronous-unwind-tables make clean lib" echo "Build failure: CFLAGS=-fno-asynchronous-unwind-tables make lib"
cat list-symbols.make.log >&2 cat list-symbols.make.log >&2
} }
rm list-symbols.make.log rm list-symbols.make.log