AuroraMiddleware/mbedtls
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix pylint errors going uncaught

Browse Source 
Make check-python-files.sh run pylint on all *.py files (in
directories where they are known to be present), rather than list
files explicitly.

Fix a bug whereby the return status of check-python-files.sh was only
based on the last file passing, i.e. errors in other files were
effectively ignored.

Make check-python-files.sh run pylint unconditionally. Since pylint3
is not critical, make all.sh to skip running check-python-files.sh if
pylint3 is not available.
This commit is contained in:
Gilles Peskine 2019-02-25 20:26:06 +01:00
parent b2c269eeee
commit aad2ebdf30
2 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tests/scripts/all.sh
View File

@ -1344,6 +1344,9 @@ component_test_zeroize () {
unset gdb_disable_aslr
}
support_check_python_files () {
type pylint3 >/dev/null 2>/dev/null
}
component_check_python_files () {
msg "Lint: Python scripts"
record_status tests/scripts/check-python-files.sh

8
tests/scripts/check-python-files.sh
View File

@ -9,10 +9,4 @@
# Run 'pylint' on Python files for programming errors and helps enforcing
# PEP8 coding standards.
if `hash pylint3 > /dev/null 2>&1`; then
pylint3 -j 2 tests/scripts/generate_test_code.py
pylint3 -j 2 tests/scripts/test_generate_test_code.py
pylint3 -j 2 tests/scripts/mbedtls_test.py
else
echo "$0: WARNING: 'pylint3' not found! Skipping checks on Python files."
fi
pylint3 -j 2 scripts/*.py tests/scripts/*.py