From c8d242f625fa89b442f1c281faeef7b4bc5be73a Mon Sep 17 00:00:00 2001 From: Gilles Peskine Date: Wed, 6 Apr 2022 22:23:45 +0200 Subject: [PATCH] set_maybe_calc_verify: $1 is intended to be auth_mode Document that this is what it is. Don't allow made-up numerical values. Signed-off-by: Gilles Peskine --- tests/ssl-opt.sh | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/ssl-opt.sh b/tests/ssl-opt.sh index df6230da6..06a115174 100755 --- a/tests/ssl-opt.sh +++ b/tests/ssl-opt.sh @@ -891,8 +891,9 @@ is_gnutls() { # disabled on the client or on the server. # # Inputs: -# * $1: 'required' or 1 if client authentication is expected, -# 'none' or 0 or absent if not. +# * $1: the value of the server auth_mode parameter. +# 'required' if client authentication is expected, +# 'none' or absent if not. # * $CONFIGS_ENABLED # # Outputs: @@ -903,8 +904,8 @@ set_maybe_calc_verify() { *\ MBEDTLS_SSL_EXTENDED_MASTER_SECRET\ *) :;; *) case ${1-} in - ''|0|none) return;; - 1|required) :;; + ''|none) return;; + required) :;; *) echo "Bad parameter 1 to set_maybe_calc_verify: $1"; exit 1;; esac esac