Clearer code to search for config.h
Don't use a function argument as a for loop variable. It worked (mostly) but Pylint frowns on it (redefined-argument-from-local) and I think Pylint has a point. If the configuration file is not found, raise an exception mentioning the search path rather than just its last element. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
This commit is contained in:
parent
13c95c4d74
commit
ce674a90c5
@ -283,9 +283,13 @@ class ConfigFile(Config):
|
|||||||
def __init__(self, filename=None):
|
def __init__(self, filename=None):
|
||||||
"""Read the Mbed TLS configuration file."""
|
"""Read the Mbed TLS configuration file."""
|
||||||
if filename is None:
|
if filename is None:
|
||||||
for filename in self.default_path:
|
for candidate in self.default_path:
|
||||||
if os.path.lexists(filename):
|
if os.path.lexists(candidate):
|
||||||
|
filename = candidate
|
||||||
break
|
break
|
||||||
|
else:
|
||||||
|
raise Exception('Mbed TLS configuration file not found',
|
||||||
|
self.default_path)
|
||||||
super().__init__()
|
super().__init__()
|
||||||
self.filename = filename
|
self.filename = filename
|
||||||
self.current_section = 'header'
|
self.current_section = 'header'
|
||||||
|
Loading…
Reference in New Issue
Block a user