improve handling of out-of-memory situations

This commit is contained in:
daan 2020-09-14 09:02:06 -07:00
parent ff7b6c54bd
commit 840eba2874
2 changed files with 13 additions and 11 deletions

View File

@ -298,12 +298,12 @@ static void* mi_region_try_alloc(size_t blocks, bool* commit, bool* is_large, bo
if (any_uncommitted) {
mi_assert_internal(!info.x.is_large);
bool commit_zero = false;
bool ok = _mi_mem_commit(p, blocks * MI_SEGMENT_SIZE, &commit_zero, tld);
if (commit_zero) *is_zero = true;
if (!ok)
{
if (!_mi_mem_commit(p, blocks * MI_SEGMENT_SIZE, &commit_zero, tld)) {
// failed to commit! unclaim and return
mi_bitmap_unclaim(&region->in_use, 1, blocks, bit_idx);
return NULL;
}
if (commit_zero) *is_zero = true;
}
}
else {

View File

@ -207,15 +207,17 @@ static void mi_segment_protect(mi_segment_t* segment, bool protect, mi_os_tld_t*
mi_assert_internal(MI_SECURE <= 1 || segment->page_kind >= MI_PAGE_LARGE);
uint8_t* start = (uint8_t*)segment + segment->segment_size - os_psize;
if (protect && !segment->mem_is_committed) {
if (protect) {
// ensure secure page is committed
#if (MI_DEBUG>1)
bool ok =
#endif
_mi_mem_commit(start, os_psize, NULL, tld);
mi_assert_internal(ok);
}
if (_mi_mem_commit(start, os_psize, NULL, tld)) { // if this fails that is ok (as it is an unaccessible page)
mi_segment_protect_range(start, os_psize, protect);
}
}
}
else {
mi_segment_protect_range(start, os_psize, protect);
}
}
else {
// or protect every page
const size_t page_size = mi_segment_page_size(segment);