AuroraMiddleware/protobuf
1
0
Fork 0
Code Issues 1 Pull Requests Projects Releases Wiki Activity

Updates for PR comments.

Browse Source
This commit is contained in:
Josh Haberman 2016-04-29 09:39:26 -07:00
parent 30a2f70eb3
commit 1ce5bd8e84
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
benchmarks/Makefile.am
View File

@ -27,8 +27,9 @@ nodist_generate_datasets_SOURCES = \
$(benchmarks_protoc_outputs) \
$(benchmarks_protoc_outputs_proto2)
# Explicit deps beacuse BUILT_SOURCES are only done before a "make all/check"
# Explicit deps because BUILT_SOURCES are only done before a "make all/check"
# so a direct "make test_cpp" could fail if parallel enough.
# See: https://www.gnu.org/software/automake/manual/html_node/Built-Sources-Example.html#Recording-Dependencies-manually
generate_datasets-generate_datasets.$(OBJEXT): benchmarks.pb.h google_message1.h google_message2.h
$(benchmarks_protoc_outputs): protoc_middleman

8
benchmarks/benchmarks.proto
View File

@ -68,16 +68,16 @@ message Metric {
// A unique ID for these results. Used for de-duping.
string guid = 1;
// The tags specify exactly what benchmark was run against the dataset.
// The labels specify exactly what benchmark was run against the dataset.
// The specific benchmark suite can decide what these mean, but here are
// some common tags that have a predefined meaning:
// some common labels that have a predefined meaning:
//
// - "dataset": for tests that pertain to a specific dataset.
//
// For example:
//
// # Tests parsing from binary proto string using arenas.
// tags={
// labels={
// dataset: "testalltypes",
// op: "parse",
// format: "binaryproto",
@ -86,7 +86,7 @@ message Metric {
// }
//
// # Tests serializing to JSON string.
// tags={
// labels={
// dataset: "testalltypes",
// op: "serialize",
// format: "json",