AuroraMiddleware/protobuf
1
0
Fork 0
Code Issues 1 Pull Requests Projects Releases Wiki Activity

Add $ before url_prefix_len to make it a variable. (#3668)

Browse Source 
* Add $ before url_prefix_len to make it a variable.

* Remove unnecessary string length check

* Remove useless $type_url_len
This commit is contained in:
Paul Yang 2017-09-20 22:59:13 -07:00 committed by GitHub
parent eade82c836
commit 2b0ee3fdf6
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
php/src/Google/Protobuf/Any.php
View File

@ -207,16 +207,14 @@ class Any extends \Google\Protobuf\Internal\Message
public function unpack()
{
// Get fully qualifed name from type url.
$type_url_len = strlen($this->type_url);
$url_prifix_len = strlen(Any::TYPE_URL_PREFIX);
if ($type_url_len < url_prifix_len ||
substr($this->type_url, 0, $url_prifix_len) !=
if (substr($this->type_url, 0, $url_prifix_len) !=
Any::TYPE_URL_PREFIX) {
throw new \Exception(
"Type url needs to be type.googleapis.com/fully-qulified");
}
$fully_qualifed_name =
substr($this->type_url, $url_prifix_len, $type_url_len);
substr($this->type_url, $url_prifix_len);
// Create message according to fully qualified name.
$pool = DescriptorPool::getGeneratedPool();