AuroraMiddleware/protobuf
1
0
Fork 0
Code Issues 1 Pull Requests Projects Releases Wiki Activity

Use Length to check string/bytes fields for emptiness - it's faster than an equality check.

Browse Source
This commit is contained in:
Jon Skeet 2015-06-12 11:18:37 +01:00
parent 8fcde2cabd
commit 4352744859
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/google/protobuf/compiler/csharp/csharp_primitive_field.cc
View File

@ -52,6 +52,10 @@ PrimitiveFieldGenerator::PrimitiveFieldGenerator(
// TODO(jonskeet): Make this cleaner... // TODO(jonskeet): Make this cleaner...
is_value_type = descriptor->type() != FieldDescriptor::TYPE_STRING is_value_type = descriptor->type() != FieldDescriptor::TYPE_STRING
&& descriptor->type() != FieldDescriptor::TYPE_BYTES; && descriptor->type() != FieldDescriptor::TYPE_BYTES;
if (!is_value_type) {
variables_["has_property_check"] = variables_["property_name"] + ".Length != 0";
variables_["other_has_property_check"] = "other." + variables_["property_name"] + ".Length != 0";
}
} }
PrimitiveFieldGenerator::~PrimitiveFieldGenerator() { PrimitiveFieldGenerator::~PrimitiveFieldGenerator() {
@ -90,9 +94,11 @@ void PrimitiveFieldGenerator::GenerateMergingCode(io::Printer* printer) {
} }
void PrimitiveFieldGenerator::GenerateParsingCode(io::Printer* printer) { void PrimitiveFieldGenerator::GenerateParsingCode(io::Printer* printer) {
// Note: invoke the property setter rather than writing straight to the field,
// so that we can normalize "null to empty" for strings and bytes.
printer->Print( printer->Print(
variables_, variables_,
"$name$_ = input.Read$capitalized_type_name$();\n"); "$property_name$ = input.Read$capitalized_type_name$();\n");
} }
void PrimitiveFieldGenerator::GenerateSerializationCode(io::Printer* printer) { void PrimitiveFieldGenerator::GenerateSerializationCode(io::Printer* printer) {