AuroraMiddleware/protobuf
1
0
Fork 0
Code Issues 1 Pull Requests Projects Releases Wiki Activity

optimize writing fixed32 and fixed64, fix benchmark

Browse Source
This commit is contained in:
Jan Tattermusch 2020-06-09 17:59:32 +02:00
parent 5eec497d3b
commit 549dc9a412
2 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
csharp/src/Google.Protobuf.Benchmarks/WriteRawPrimitivesBenchmark.cs
View File

@ -240,7 +240,7 @@ namespace Google.Protobuf.Benchmarks
[Benchmark]
public void WriteFixed64_WriteContext()
{
const int encodedSize = sizeof(uint);
const int encodedSize = sizeof(ulong);
var span = new Span<byte>(outputBuffer);
WriteContext.Initialize(ref span, out WriteContext ctx);
for (uint i = 0; i < BytesToWrite / encodedSize; i++)

17
csharp/src/Google.Protobuf/WritingPrimitives.cs
View File

@ -31,6 +31,7 @@
#endregion
using System;
using System.Buffers.Binary;
using System.Runtime.CompilerServices;
using System.Runtime.InteropServices;
using System.Security;
@ -351,7 +352,8 @@ namespace Google.Protobuf
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static void WriteRawLittleEndian32(ref Span<byte> buffer, ref WriterInternalState state, uint value)
{
if (state.position + 4 > state.limit)
const int length = sizeof(uint);
if (state.position + length > state.limit)
{
WriteRawByte(ref buffer, ref state, (byte)value);
WriteRawByte(ref buffer, ref state, (byte)(value >> 8));
@ -360,17 +362,16 @@ namespace Google.Protobuf
}
else
{
buffer[state.position++] = ((byte)value);
buffer[state.position++] = ((byte)(value >> 8));
buffer[state.position++] = ((byte)(value >> 16));
buffer[state.position++] = ((byte)(value >> 24));
BinaryPrimitives.WriteUInt32LittleEndian(buffer.Slice(state.position), value);
state.position += length;
}
}
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static void WriteRawLittleEndian64(ref Span<byte> buffer, ref WriterInternalState state, ulong value)
{
if (state.position + 8 > state.limit)
const int length = sizeof(ulong);
if (state.position + length > state.limit)
{
WriteRawByte(ref buffer, ref state, (byte)value);
WriteRawByte(ref buffer, ref state, (byte)(value >> 8));
@ -383,6 +384,10 @@ namespace Google.Protobuf
}
else
{
// TODO(jtattermusch): According to the benchmarks, writing byte-by-byte is actually faster
// than using BinaryPrimitives.WriteUInt64LittleEndian.
// This is strange especially because WriteUInt32LittleEndian seems to be much faster
// in terms of throughput.
buffer[state.position++] = ((byte)value);
buffer[state.position++] = ((byte)(value >> 8));
buffer[state.position++] = ((byte)(value >> 16));