AuroraMiddleware/protobuf
1
0
Fork 0
Code Issues 1 Pull Requests Projects Releases Wiki Activity

Fix RepeatedField#first in Ruby gem (#5293)

Browse Source 
Given an argument, the previous implementation was off by one
(`.first(2)` would return 3 elements) compared to the `Enumerable#first`
method.
This commit is contained in:
Toby Hsieh 2018-10-29 11:32:50 -07:00 committed by Paul Yang
parent 3025a06607
commit 63d2f3bc80
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ruby/lib/google/protobuf/repeated_field.rb
View File

@ -79,7 +79,7 @@ module Google
def first(n=nil)
n ? self[0..n] : self[0]
n ? self[0...n] : self[0]
end

8
ruby/tests/repeated_field_test.rb
View File

@ -28,7 +28,10 @@ class RepeatedFieldTest < Test::Unit::TestCase
m = TestMessage.new
repeated_field_names(TestMessage).each do |field_name|
assert_nil m.send(field_name).first
assert_equal [], m.send(field_name).first(0)
assert_equal [], m.send(field_name).first(1)
end
fill_test_msg(m)
assert_equal -10, m.repeated_int32.first
assert_equal -1_000_000, m.repeated_int64.first
@ -41,6 +44,11 @@ class RepeatedFieldTest < Test::Unit::TestCase
assert_equal "bar".encode!('ASCII-8BIT'), m.repeated_bytes.first
assert_equal TestMessage2.new(:foo => 1), m.repeated_msg.first
assert_equal :A, m.repeated_enum.first
assert_equal [], m.repeated_int32.first(0)
assert_equal [-10], m.repeated_int32.first(1)
assert_equal [-10, -11], m.repeated_int32.first(2)
assert_equal [-10, -11], m.repeated_int32.first(3)
end