Destruct CodedOutputStream instead of using Trim()

This commit is contained in:
Martin Pärtel 2020-02-12 08:47:24 +02:00 committed by Adam Cozzette
parent f6902d6afe
commit 82a057596e

View File

@ -2229,17 +2229,19 @@ bool CommandLineInterface::WriteDescriptorSet(
io::FileOutputStream out(fd);
io::CodedOutputStream coded_out(&out);
// Determinism is useful here because build outputs are sometimes checked
// into version control.
coded_out.SetSerializationDeterministic(true);
if (!file_set.SerializeToCodedStream(&coded_out)) {
std::cerr << descriptor_set_out_name_ << ": " << strerror(out.GetErrno())
<< std::endl;
out.Close();
return false;
{
io::CodedOutputStream coded_out(&out);
// Determinism is useful here because build outputs are sometimes checked
// into version control.
coded_out.SetSerializationDeterministic(true);
if (!file_set.SerializeToCodedStream(&coded_out)) {
std::cerr << descriptor_set_out_name_ << ": " << strerror(out.GetErrno())
<< std::endl;
out.Close();
return false;
}
}
coded_out.Trim();
if (!out.Close()) {
std::cerr << descriptor_set_out_name_ << ": " << strerror(out.GetErrno())
<< std::endl;