AuroraMiddleware/protobuf
1
0
Fork 0
Code Issues 1 Pull Requests Projects Releases Wiki Activity

Improve comment about warning being incomplete.

Browse Source
This commit is contained in:
Thomas Van Lenten 2018-11-14 14:20:18 -05:00
parent 7fa7fbaf16
commit 8dadfda1e3
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
objectivec/GPBMessage.m
View File

@ -3252,6 +3252,13 @@ static void ResolveIvarSet(__unsafe_unretained GPBFieldDescriptor *field,
#if defined(DEBUG) && DEBUG
if (extensionMap_.count) {
// Hint to go along with the docs on GPBMessage about this.
//
// Note: This is incomplete, in that it only checked the "root" message,
// if a sub message in a field has extensions, the issue still exists. A
// recursive check could be done here (like the work in
// GPBMessageDropUnknownFieldsRecursively()), but that has the potential to
// be expensive and could slow down serialization in DEBUG enought to cause
// developers other problems.
NSLog(@"Warning: writing out a GPBMessage (%@) via NSCoding and it"
@" has %ld extensions; when read back in, those fields will be"
@" in the unknownFields property instead.",