AuroraMiddleware/protobuf
1
0
Fork 0
Code Issues 1 Pull Requests Projects Releases Wiki Activity

C# cleanup - assorted nits

Browse Source
This commit is contained in:
Jan Tattermusch 2015-07-15 19:35:38 -07:00
parent 19cf9d1e00
commit ab5fffcc9e
5 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
csharp/src/ProtocolBuffers/Collections/RepeatedField.cs
View File

@ -44,9 +44,9 @@ namespace Google.Protobuf.Collections
public sealed class RepeatedField<T> : IList<T>, IList, IDeepCloneable<RepeatedField<T>>, IEquatable<RepeatedField<T>>, IFreezable
{
private static readonly T[] EmptyArray = new T[0];
private const int MinArraySize = 8;
private bool frozen;
private const int MinArraySize = 8;
private T[] array = EmptyArray;
private int count = 0;
@ -259,7 +259,6 @@ namespace Google.Protobuf.Collections
public int Count { get { return count; } }
// TODO(jonskeet): If we implement freezing, make this reflect it.
public bool IsReadOnly { get { return IsFrozen; } }
public void Add(RepeatedField<T> values)

1
csharp/src/ProtocolBuffers/FrameworkPortability.cs
View File

@ -40,6 +40,7 @@ namespace Google.Protobuf
/// </summary>
internal static class FrameworkPortability
{
// TODO(jtattermusch): is this still a thing?
// The value of RegexOptions.Compiled is 8. We can test for the presence at
// execution time using Enum.IsDefined, so a single build will do the right thing
// on each platform.

6
csharp/src/ProtocolBuffers/InvalidProtocolBufferException.cs
View File

@ -79,12 +79,6 @@ namespace Google.Protobuf
"Protocol message end-group tag did not match expected tag.");
}
internal static InvalidProtocolBufferException InvalidWireType()
{
return new InvalidProtocolBufferException(
"Protocol message tag had invalid wire type.");
}
internal static InvalidProtocolBufferException RecursionLimitExceeded()
{
return new InvalidProtocolBufferException(

1
csharp/src/ProtocolBuffers/ProtocolBuffers.csproj
View File

@ -111,7 +111,6 @@
<ItemGroup>
<None Include="Google.Protobuf.nuspec" />
</ItemGroup>
<ItemGroup />
<Import Project="$(MSBuildExtensionsPath32)\Microsoft\Portable\$(TargetFrameworkVersion)\Microsoft.Portable.CSharp.targets" />
<!-- To modify your build process, add your task inside one of the targets below and uncomment it.
Other similar extension points exist, see Microsoft.Common.targets.

2
csharp/src/ProtocolBuffers/Reflection/IFieldAccessor.cs
View File

@ -42,7 +42,7 @@ namespace Google.Protobuf.Reflection
/// </summary>
FieldDescriptor Descriptor { get; }
// TODO: Should the argument type for these messages by IReflectedMessage?
// TODO: Should the argument type for these messages be IReflectedMessage?
/// <summary>
/// Clears the field in the specified message. (For repeated fields,