AuroraMiddleware/protobuf
1
0
Fork 0
Code Issues 1 Pull Requests Projects Releases Wiki Activity

Optimizations for loading of descriptors in PHP:

Browse Source 
1. Eliminate hex2bin() call by putting binary data directly into PHP
   strings.
2. upb optimizations, including a new hash function.
This commit is contained in:
Joshua Haberman 2020-10-14 21:46:42 -07:00
parent 2187eb0448
commit d140b1cdce
3 changed files with 1135 additions and 911 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1225
php/ext/google/protobuf/php-upb.c
View File

File diff suppressed because it is too large Load Diff

798
php/ext/google/protobuf/php-upb.h
View File

File diff suppressed because it is too large Load Diff

23
src/google/protobuf/compiler/php/php_generator.cc
View File

@ -1018,7 +1018,6 @@ void GenerateAddFileToPool(
} }
printer->Print("'\n"); printer->Print("'\n");
Outdent(printer); Outdent(printer);
printer->Print( printer->Print(
", true);\n\n"); ", true);\n\n");
@ -1150,16 +1149,28 @@ void GenerateAddFilesToPool(
string files_data; string files_data;
sorted_file_set.SerializeToString(&files_data); sorted_file_set.SerializeToString(&files_data);
printer->Print("$pool->internalAddGeneratedFile(hex2bin(\n"); printer->Print("$pool->internalAddGeneratedFile(\n");
Indent(printer); Indent(printer);
printer->Print("'");
printer->Print( for (auto ch : files_data) {
"\"^data^\"\n", switch (ch) {
"data", BinaryToHex(files_data)); case '\\':
printer->Print(R"(\\)");
break;
case '\'':
printer->Print(R"(\')");
break;
default:
printer->Print("^char^", "char", std::string(1, ch));
break;
}
}
printer->Print("'\n");
Outdent(printer); Outdent(printer);
printer->Print( printer->Print(
"), true);\n"); ", true);\n");
printer->Print( printer->Print(
"static::$is_initialized = true;\n"); "static::$is_initialized = true;\n");