AuroraMiddleware/protobuf
1
0
Fork 0
Code Issues 1 Pull Requests Projects Releases Wiki Activity

address a few TODOs

Browse Source
This commit is contained in:
Jan Tattermusch 2020-06-08 16:23:33 +02:00
parent 43dcee2fa9
commit e14a5c8fe6
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
csharp/src/Google.Protobuf.Test/MessageParsingHelpers.cs
View File

@ -121,7 +121,14 @@ namespace Google.Protobuf
message.WriteTo(singleSpan);
Assert.AreEqual(bytes, singleSpan.ToArray());
// TODO: also test different chunk sizes for IBufferWriter
// test for different IBufferWriter.GetSpan() segment sizes
for (int blockSize = 1; blockSize < 256; blockSize *= 2)
{
var segmentedBufferWriter = new ArrayBufferWriter<byte>();
segmentedBufferWriter.MaxGrowBy = blockSize;
message.WriteTo(segmentedBufferWriter);
Assert.AreEqual(bytes, bufferWriter.WrittenSpan.ToArray());
}
}
}
}

2
csharp/src/Google.Protobuf/MessageExtensions.cs
View File

@ -160,8 +160,6 @@ namespace Google.Protobuf
WriteContext.Initialize(output, out WriteContext ctx);
WritingPrimitivesMessages.WriteRawMessage(ref ctx, message);
ctx.Flush();
// TODO: handling errors when IBufferWriter is used?
}
/// <summary>