AuroraMiddleware/protobuf
1
0
Fork 0
Code Issues 1 Pull Requests Projects Releases Wiki Activity

Fixed quadratic behavior in JSPB deserialization of repeated fields (#2117) (#2146)

Browse Source 
Currently deserialization of a non-packed binary repeated field is quadratic in
the number of elements, because each time we parse a new element we copy over
all elements we have parsed so far. This CL fixes the performance problem by
having the generated deserialization code just call addX() instead of using
getX() and setX().
This commit is contained in:
Adam Cozzette 2016-09-21 10:39:23 -07:00 committed by Bo Yang
parent 31dd4998df
commit f7bb8477a8
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/google/protobuf/compiler/js/js_generator.cc
View File

@ -2850,13 +2850,9 @@ void Generator::GenerateClassDeserializeBinaryField(
}
if (field->is_repeated() && !field->is_packed()) {
// Repeated fields receive a |value| one at at a time; append to array
// returned by get$name$(). Annoyingly, we have to call 'set' after
// changing the array.
printer->Print(" msg.get$name$().push(value);\n", "name",
JSGetterName(options, field));
printer->Print(" msg.set$name$(msg.get$name$());\n", "name",
JSGetterName(options, field));
printer->Print(
" msg.add$name$(value);\n", "name",
JSGetterName(options, field, BYTES_DEFAULT, /* drop_list = */ true));
} else {
// Singular fields, and packed repeated fields, receive a |value| either
// as the field's value or as the array of all the field's values; set