9abf6e2ab0
* WIP. * WIP. * WIP. * WIP. * WIP. * WIP. * Added some missing files. * WIP. * WIP. * Updated upb. * Extension loads, but crashes immediately. * Gets through the test suite without SEGV! Still a lot of bugs to fix, but it is a major step! 214 tests, 378 assertions, 37 failures, 147 errors, 0 pendings, 0 omissions, 0 notifications 14.0187% passed * Test and build for Ruby 3.0 * Fixed a few more bugs, efficient #inspect is almost done. 214 tests, 134243 assertions, 30 failures, 144 errors, 0 pendings, 0 omissions, 0 notifications 18.6916% passed * Fixed message hash initialization and encode depth checking. 214 tests, 124651 assertions, 53 failures, 70 errors, 0 pendings, 0 omissions, 0 notifications 42.5234% passed * A bunch of fixes to failing tests, now 70% passing. 214 tests, 202091 assertions, 41 failures, 23 errors, 0 pendings, 0 omissions, 0 notifications 70.0935% passed * More than 80% of tests are passing now. 214 tests, 322331 assertions, 30 failures, 9 errors, 0 pendings, 0 omissions, 0 notifications 81.7757% passed Unfortunately there is also a sporadic bug/segfault hanging around that appears to be GC-related. * Add linux/ruby30 and macos/ruby30 * Use rvm master for 3.0.0-preview2 * Over 90% of tests are passing! 214 tests, 349898 assertions, 15 failures, 1 errors, 0 pendings, 0 omissions, 0 notifications 92.5234% passed * Passes all tests! 214 tests, 369388 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed * A bunch of cleanup. 1. Removed a bunch of internal-only symbols from headers. 2. Required a frozen check to get a non-const pointer to a map or array. 3. De-duplicated the code to get a type argument for Map/RepeatedField. * Removed a bunch more stuff from protobuf.h. There is an intermittent assert failure. Intermittent failure: ruby: ../../../../ext/google/protobuf_c/protobuf.c:263: ObjectCache_Add: Assertion `rb_funcall(obj_cache2, (__builtin_constant_p("[]") ? __extension__ ({ static ID rb_intern_id_cache; if (!rb_intern_id_cache) rb_intern_id_cache = rb_intern2((("[]") ), (long)strlen(("[]"))); (ID) rb_intern_id_cache; }) : rb_intern("[]")), 1, key_rb) == val' failed * Removed a few more things from protobuf.h. * Ruby 3.0.0-preview2 to 3.0.0 * Require rake-compiler-dock >= 1.1.0 * More progress, fighting with the object cache. * Passes on all Ruby versions! * Updated and clarified comment regarding WeakMap. * Fixed the wyhash compile. * Fixed conformance tests for Ruby. Conformance results now look like: RUBYLIB=../ruby/lib:. ./conformance-test-runner --enforce_recommended --failure_list failure_list_ruby.txt --text_format_failure_list text_format_failure_list_ruby.txt ./conformance_ruby.rb CONFORMANCE TEST BEGIN ==================================== CONFORMANCE SUITE PASSED: 1955 successes, 0 skipped, 58 expected failures, 0 unexpected failures. CONFORMANCE TEST BEGIN ==================================== CONFORMANCE SUITE PASSED: 0 successes, 111 skipped, 8 expected failures, 0 unexpected failures. Fixes include: - Changed Ruby compiler to no longer reject proto2 maps. - Changed Ruby compiler to emit a warning when proto2 extensions are present instead of rejecting the .proto file completely. - Fixed conformance tests to allow proto2 and look up message by name instead of hardcoding a specific list of messages. - Fixed conformance test to support the "ignore unknown" option for JSON. - Fixed conformance test to properly report serialization errors. * Removed debug printf and fixed #inspect for floats. * Fixed compatibility test to have proper semantics for #to_json. * Updated Makefile.am with new file list. * Don't try to copy wyhash when inside Docker. * Fixed bug where we would forget that a sub-object is frozen in Ruby >=2.7. * Avoid exporting unneeded symbols and refactored a bit of code. * Some more refactoring. * Simplified and added more comments. * Some more comments and simplification. Added a missing license block. Co-authored-by: Masaki Hara <hara@wantedly.com>
147 lines
4.7 KiB
Ruby
Executable File
147 lines
4.7 KiB
Ruby
Executable File
#!/usr/bin/env ruby
|
|
#
|
|
# Protocol Buffers - Google's data interchange format
|
|
# Copyright 2008 Google Inc. All rights reserved.
|
|
# https://developers.google.com/protocol-buffers/
|
|
#
|
|
# Redistribution and use in source and binary forms, with or without
|
|
# modification, are permitted provided that the following conditions are
|
|
# met:
|
|
#
|
|
# * Redistributions of source code must retain the above copyright
|
|
# notice, this list of conditions and the following disclaimer.
|
|
# * Redistributions in binary form must reproduce the above
|
|
# copyright notice, this list of conditions and the following disclaimer
|
|
# in the documentation and/or other materials provided with the
|
|
# distribution.
|
|
# * Neither the name of Google Inc. nor the names of its
|
|
# contributors may be used to endorse or promote products derived from
|
|
# this software without specific prior written permission.
|
|
#
|
|
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
require 'conformance_pb'
|
|
require 'google/protobuf/test_messages_proto3_pb'
|
|
require 'google/protobuf/test_messages_proto2_pb'
|
|
|
|
$test_count = 0
|
|
$verbose = false
|
|
|
|
def do_test(request)
|
|
test_message = ProtobufTestMessages::Proto3::TestAllTypesProto3.new
|
|
response = Conformance::ConformanceResponse.new
|
|
descriptor = Google::Protobuf::DescriptorPool.generated_pool.lookup(request.message_type)
|
|
|
|
unless descriptor
|
|
response.skipped = "Unknown message type: " + request.message_type
|
|
end
|
|
|
|
begin
|
|
case request.payload
|
|
when :protobuf_payload
|
|
begin
|
|
test_message = descriptor.msgclass.decode(request.protobuf_payload)
|
|
rescue Google::Protobuf::ParseError => err
|
|
response.parse_error = err.message.encode('utf-8')
|
|
return response
|
|
end
|
|
|
|
when :json_payload
|
|
begin
|
|
options = {}
|
|
if request.test_category == :JSON_IGNORE_UNKNOWN_PARSING_TEST
|
|
options[:ignore_unknown_fields] = true
|
|
end
|
|
test_message = descriptor.msgclass.decode_json(request.json_payload, options)
|
|
rescue Google::Protobuf::ParseError => err
|
|
response.parse_error = err.message.encode('utf-8')
|
|
return response
|
|
end
|
|
|
|
when :text_payload
|
|
begin
|
|
response.skipped = "Ruby doesn't support text format"
|
|
return response
|
|
end
|
|
|
|
when nil
|
|
fail "Request didn't have payload"
|
|
end
|
|
|
|
case request.requested_output_format
|
|
when :UNSPECIFIED
|
|
fail 'Unspecified output format'
|
|
|
|
when :PROTOBUF
|
|
begin
|
|
response.protobuf_payload = test_message.to_proto
|
|
rescue Google::Protobuf::ParseError => err
|
|
response.serialize_error = err.message.encode('utf-8')
|
|
end
|
|
|
|
when :JSON
|
|
begin
|
|
response.json_payload = test_message.to_json
|
|
rescue Google::Protobuf::ParseError => err
|
|
response.serialize_error = err.message.encode('utf-8')
|
|
end
|
|
|
|
when nil
|
|
fail "Request didn't have requested output format"
|
|
end
|
|
rescue StandardError => err
|
|
response.runtime_error = err.message.encode('utf-8')
|
|
end
|
|
|
|
response
|
|
end
|
|
|
|
# Returns true if the test ran successfully, false on legitimate EOF.
|
|
# If EOF is encountered in an unexpected place, raises IOError.
|
|
def do_test_io
|
|
length_bytes = STDIN.read(4)
|
|
return false if length_bytes.nil?
|
|
|
|
length = length_bytes.unpack('V').first
|
|
serialized_request = STDIN.read(length)
|
|
if serialized_request.nil? || serialized_request.length != length
|
|
fail IOError
|
|
end
|
|
|
|
request = Conformance::ConformanceRequest.decode(serialized_request)
|
|
|
|
response = do_test(request)
|
|
|
|
serialized_response = Conformance::ConformanceResponse.encode(response)
|
|
STDOUT.write([serialized_response.length].pack('V'))
|
|
STDOUT.write(serialized_response)
|
|
STDOUT.flush
|
|
|
|
if $verbose
|
|
STDERR.puts("conformance_ruby: request=#{request.to_json}, " \
|
|
"response=#{response.to_json}\n")
|
|
end
|
|
|
|
$test_count += 1
|
|
|
|
true
|
|
end
|
|
|
|
loop do
|
|
unless do_test_io
|
|
STDERR.puts('conformance_ruby: received EOF from test runner ' \
|
|
"after #{$test_count} tests, exiting")
|
|
break
|
|
end
|
|
end
|