AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
33d606412d
qt5base-lts/cmake/FindGSSAPI.cmake

59 lines
1.9 KiB
CMake
Raw Normal View History

Add license headers to cmake files CMakeLists.txt and .cmake files of significant size (more than 2 lines according to our check in tst_license.pl) now have the copyright and license header. Existing copyright statements remain intact Task-number: QTBUG-88621 Change-Id: I3b98cdc55ead806ec81ce09af9271f9b95af97fa Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
2022-07-05 11:26:52 +00:00
# Copyright (C) 2022 The Qt Company Ltd.
Change the license of all CMakeLists.txt and *.cmake files to BSD Task-number: QTBUG-105718 Change-Id: I5d3ef70a31235868b9be6cb479b7621bf2a8ba39 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
2022-08-19 13:21:34 +00:00
# SPDX-License-Identifier: BSD-3-Clause
Add license headers to cmake files CMakeLists.txt and .cmake files of significant size (more than 2 lines according to our check in tst_license.pl) now have the copyright and license header. Existing copyright statements remain intact Task-number: QTBUG-88621 Change-Id: I3b98cdc55ead806ec81ce09af9271f9b95af97fa Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
2022-07-05 11:26:52 +00:00
CMake: Mark all find_package(PkgConfig) to be quiet This reduces the amount of warning messages when the pkg-config feature is disabled. Task-number: QTBUG-85276 Change-Id: I11a6dfb6273a1e48c47d1ef5c1a5f70ba990fbc0 Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
2020-06-26 18:41:29 +00:00
find_package(PkgConfig QUIET)
CMake: Unify usage of pkg_check_modules According to the CMake documentation, IMPORTED_TARGET should be specified before the moduleSpec, and after QUIET. Additionally, double-quote the moduleSpec everywhere, since before, it was only quoted in some cases. While this is not required for pkg_check_modules to work, it unifies the coding style. Pick-to: 6.5 Change-Id: Ic8ad708a8146f9b39ee40e9a719412441e231452 Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
2022-12-26 18:25:14 +00:00
pkg_check_modules(PC_GSSAPI QUIET "krb5-gssapi")
Fix finding GSSAPI The package is called mit-krb5-gssapi on Ubuntu, and the LIBDIR variable was missing an underscore. Pick-to: 6.3 6.2 Change-Id: I85b5603c1161f33462aa71bbd522d40dd7489405 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
2022-01-28 13:34:00 +00:00
if (NOT PC_GSSAPI_FOUND)
CMake: Unify usage of pkg_check_modules According to the CMake documentation, IMPORTED_TARGET should be specified before the moduleSpec, and after QUIET. Additionally, double-quote the moduleSpec everywhere, since before, it was only quoted in some cases. While this is not required for pkg_check_modules to work, it unifies the coding style. Pick-to: 6.5 Change-Id: Ic8ad708a8146f9b39ee40e9a719412441e231452 Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
2022-12-26 18:25:14 +00:00
pkg_check_modules(PC_GSSAPI QUIET "mit-krb5-gssapi")
Fix finding GSSAPI The package is called mit-krb5-gssapi on Ubuntu, and the LIBDIR variable was missing an underscore. Pick-to: 6.3 6.2 Change-Id: I85b5603c1161f33462aa71bbd522d40dd7489405 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
2022-01-28 13:34:00 +00:00
endif()
Regenerate files after dev -> wip/cmake merge Note the following bigger things that had to be done: Handle GSS library / feature with a new custom find module. Implement rudimentary support for relocatability (does not currently handle extprefix). Change-Id: Ic6cd27dda7ebca9829f51cb42ea76fff6d1767ef Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2019-10-11 14:55:55 +00:00
find_path(GSSAPI_INCLUDE_DIRS
NAMES gssapi/gssapi.h
HINTS ${PC_GSSAPI_INCLUDEDIR}
Fix finding GSSAPI The package is called mit-krb5-gssapi on Ubuntu, and the LIBDIR variable was missing an underscore. Pick-to: 6.3 6.2 Change-Id: I85b5603c1161f33462aa71bbd522d40dd7489405 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
2022-01-28 13:34:00 +00:00
)
Regenerate files after dev -> wip/cmake merge Note the following bigger things that had to be done: Handle GSS library / feature with a new custom find module. Implement rudimentary support for relocatability (does not currently handle extprefix). Change-Id: Ic6cd27dda7ebca9829f51cb42ea76fff6d1767ef Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2019-10-11 14:55:55 +00:00
Prefer GSS.framework on macOS over libgssapi_krb5.tbd when using vcpkg On macOS, vcpkg toolchain sets the value of CMAKE_FIND_FRAMEWORK and CMAKE_FIND_APPBUNDLE to LAST which causes an issue when it comes to GSSAPI. This change in behavior leads to FindGSSAPI.cmake finding `usr/lib/libgssapi_krb5.tbd → Kerberos.framework` instead, which is not exactly what we want, and it misses some necessary symbols, and as a result Network fails to build.¹ We need to make sure that we find `GSS.framework`. Here by dropping the alternative name on Apple platform, we end up getting the Framework even if vcpkg prefer finding the framework LAST. [1]: https://github.com/microsoft/vcpkg/issues/23782 Pick-to: 6.5 Change-Id: I0e7e6272dcb0fdf2c746149d2969468d66ca9ec2 Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
2023-05-17 11:48:29 +00:00
# On macOS, vcpkg opts for finding frameworks LAST. This is generally fine;
# however, in the case of GSSAPI, `usr/lib/libgssapi_krb5.tbd` which is a
# symlink to `Kerberos.framework` misses a few symols, e.g.,
# `___gss_c_nt_hostbased_service_oid_desc`, and it causes build failure.
# So, we need to make sure that we find `GSS.framework`.
set(gssapi_library_names
GSS # framework
gss # solaris
gssapi # FreeBSD
gssapi_krb5
)
Resolve an issue with detecting GSSAPI on macOS Spack, like VcPkg, sets the `CMAKE_FIND_FRAMEWORK` to `LAST`, as a result, similar to VcPkg, when Spack is used, FindGSSAPI opts for `gssapi_krb5` which is not what we want. By dropping the `gssapi_krb5` from the list of alternative names we can resolve this without much tinkering with internals of these package managers. Pick-to: 6.5 6.6 Fixes: QTBUG-114537 Change-Id: If517c409511f58e3bed78316a2030393dc249a40 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Alexey Edelev <alexey.edelev@qt.io> Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
2023-06-14 08:56:06 +00:00
if(APPLE)
Prefer GSS.framework on macOS over libgssapi_krb5.tbd when using vcpkg On macOS, vcpkg toolchain sets the value of CMAKE_FIND_FRAMEWORK and CMAKE_FIND_APPBUNDLE to LAST which causes an issue when it comes to GSSAPI. This change in behavior leads to FindGSSAPI.cmake finding `usr/lib/libgssapi_krb5.tbd → Kerberos.framework` instead, which is not exactly what we want, and it misses some necessary symbols, and as a result Network fails to build.¹ We need to make sure that we find `GSS.framework`. Here by dropping the alternative name on Apple platform, we end up getting the Framework even if vcpkg prefer finding the framework LAST. [1]: https://github.com/microsoft/vcpkg/issues/23782 Pick-to: 6.5 Change-Id: I0e7e6272dcb0fdf2c746149d2969468d66ca9ec2 Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
2023-05-17 11:48:29 +00:00
list(REMOVE_ITEM gssapi_library_names "gssapi_krb5")
endif()
Regenerate files after dev -> wip/cmake merge Note the following bigger things that had to be done: Handle GSS library / feature with a new custom find module. Implement rudimentary support for relocatability (does not currently handle extprefix). Change-Id: Ic6cd27dda7ebca9829f51cb42ea76fff6d1767ef Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2019-10-11 14:55:55 +00:00
find_library(GSSAPI_LIBRARIES
NAMES
Prefer GSS.framework on macOS over libgssapi_krb5.tbd when using vcpkg On macOS, vcpkg toolchain sets the value of CMAKE_FIND_FRAMEWORK and CMAKE_FIND_APPBUNDLE to LAST which causes an issue when it comes to GSSAPI. This change in behavior leads to FindGSSAPI.cmake finding `usr/lib/libgssapi_krb5.tbd → Kerberos.framework` instead, which is not exactly what we want, and it misses some necessary symbols, and as a result Network fails to build.¹ We need to make sure that we find `GSS.framework`. Here by dropping the alternative name on Apple platform, we end up getting the Framework even if vcpkg prefer finding the framework LAST. [1]: https://github.com/microsoft/vcpkg/issues/23782 Pick-to: 6.5 Change-Id: I0e7e6272dcb0fdf2c746149d2969468d66ca9ec2 Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
2023-05-17 11:48:29 +00:00
${gssapi_library_names}
Fix finding GSSAPI The package is called mit-krb5-gssapi on Ubuntu, and the LIBDIR variable was missing an underscore. Pick-to: 6.3 6.2 Change-Id: I85b5603c1161f33462aa71bbd522d40dd7489405 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
2022-01-28 13:34:00 +00:00
HINTS ${PC_GSSAPI_LIBDIR}
Regenerate files after dev -> wip/cmake merge Note the following bigger things that had to be done: Handle GSS library / feature with a new custom find module. Implement rudimentary support for relocatability (does not currently handle extprefix). Change-Id: Ic6cd27dda7ebca9829f51cb42ea76fff6d1767ef Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2019-10-11 14:55:55 +00:00
)
include(FindPackageHandleStandardArgs)
find_package_handle_standard_args(GSSAPI DEFAULT_MSG GSSAPI_LIBRARIES GSSAPI_INCLUDE_DIRS)
if(GSSAPI_FOUND AND NOT TARGET GSSAPI::GSSAPI)
if(GSSAPI_LIBRARIES MATCHES "/([^/]+)\\.framework$")
add_library(GSSAPI::GSSAPI INTERFACE IMPORTED)
set_target_properties(GSSAPI::GSSAPI PROPERTIES
INTERFACE_LINK_LIBRARIES "${GSSAPI_LIBRARIES}")
else()
add_library(GSSAPI::GSSAPI UNKNOWN IMPORTED)
set_target_properties(GSSAPI::GSSAPI PROPERTIES
IMPORTED_LOCATION "${GSSAPI_LIBRARIES}")
endif()
set_target_properties(GSSAPI::GSSAPI PROPERTIES
INTERFACE_INCLUDE_DIRECTORIES "${GSSAPI_INCLUDE_DIRS}")
endif()
mark_as_advanced(GSSAPI_INCLUDE_DIRS GSSAPI_LIBRARIES)
include(FeatureSummary)
set_package_properties(GSSAPI PROPERTIES
DESCRIPTION "Generic Security Services Application Program Interface")
Reference in New Issue Copy Permalink