AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
e795898cc4
qt5base-lts/bin/qt-cmake-private-install.cmake.in

30 lines
1.1 KiB
CMake
Raw Normal View History

CMake: Use custom install script to support Ninja Multi-Config builds Calling cmake --install . only installs a single configuration. To install both debug and release artifacts, the install invocation needs to be done for each configuration. To keep the Coin instruction code simpler, delegate the looping over configurations to a custom CMake script, and use it in the Coin instructions. Replace all cmake --install calls in the instructions with calls to either call_host_install.yaml or call_target_install.yaml. The path to the script depends on whether we are building qtbase or another module. In the former case the script should be called from the build dir, otherwise from the install dir. The other distinction is whether the host or target env prefix needs to be added. Task-number: QTBUG-80900 Change-Id: Ied4bf739e2b1a2307f22fc79c1cfad746c8cbc44 Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
2020-05-15 09:38:53 +00:00
# Calls cmake --install ${QT_BUILD_DIR} --config <config> for each config
# with which Qt was built with.
# This is required to enable installation of all configurations of
Add reference to CMake issue in qt-cmake-private-install-cmake.in The original issue #20713 is fixed, but there's still #21475 to be fixed before we can remove qt-cmake-private-install-cmake. Extend the comment to mention this. Change-Id: I7a2d794ae23e2b8bc7bd27527cbc8a32b1e78e1b Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
2021-03-24 08:38:59 +00:00
# a Qt built with Ninja Multi-Config until the following issues are fixed:
CMake: Use custom install script to support Ninja Multi-Config builds Calling cmake --install . only installs a single configuration. To install both debug and release artifacts, the install invocation needs to be done for each configuration. To keep the Coin instruction code simpler, delegate the looping over configurations to a custom CMake script, and use it in the Coin instructions. Replace all cmake --install calls in the instructions with calls to either call_host_install.yaml or call_target_install.yaml. The path to the script depends on whether we are building qtbase or another module. In the former case the script should be called from the build dir, otherwise from the install dir. The other distinction is whether the host or target env prefix needs to be added. Task-number: QTBUG-80900 Change-Id: Ied4bf739e2b1a2307f22fc79c1cfad746c8cbc44 Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
2020-05-15 09:38:53 +00:00
# https://gitlab.kitware.com/cmake/cmake/-/issues/20713
Add reference to CMake issue in qt-cmake-private-install-cmake.in The original issue #20713 is fixed, but there's still #21475 to be fixed before we can remove qt-cmake-private-install-cmake. Extend the comment to mention this. Change-Id: I7a2d794ae23e2b8bc7bd27527cbc8a32b1e78e1b Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
2021-03-24 08:38:59 +00:00
# https://gitlab.kitware.com/cmake/cmake/-/issues/21475
CMake: Use custom install script to support Ninja Multi-Config builds Calling cmake --install . only installs a single configuration. To install both debug and release artifacts, the install invocation needs to be done for each configuration. To keep the Coin instruction code simpler, delegate the looping over configurations to a custom CMake script, and use it in the Coin instructions. Replace all cmake --install calls in the instructions with calls to either call_host_install.yaml or call_target_install.yaml. The path to the script depends on whether we are building qtbase or another module. In the former case the script should be called from the build dir, otherwise from the install dir. The other distinction is whether the host or target env prefix needs to be added. Task-number: QTBUG-80900 Change-Id: Ied4bf739e2b1a2307f22fc79c1cfad746c8cbc44 Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
2020-05-15 09:38:53 +00:00
set(configs "@__qt_configured_configs@")
CMake: Don't strip debug builds with qt-cmake-private-install in CI This provides better stack traces and easier debugging in CI VMs. Put the MSVC check for disabling stripping into the same place so there's one location to decide whether stripping should happen. Amends 60d804c56769de82e658205bec687b83833a61e9 Pick-to: 6.6 Fixes: QTBUG-118070 Change-Id: I4684036c8a5a137d14eea58954b34fe1ceb7f804 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
2023-10-16 16:04:06 +00:00
set(should_skip_strip "@__qt_skip_strip_installed_artifacts@")
CMake: Use custom install script to support Ninja Multi-Config builds Calling cmake --install . only installs a single configuration. To install both debug and release artifacts, the install invocation needs to be done for each configuration. To keep the Coin instruction code simpler, delegate the looping over configurations to a custom CMake script, and use it in the Coin instructions. Replace all cmake --install calls in the instructions with calls to either call_host_install.yaml or call_target_install.yaml. The path to the script depends on whether we are building qtbase or another module. In the former case the script should be called from the build dir, otherwise from the install dir. The other distinction is whether the host or target env prefix needs to be added. Task-number: QTBUG-80900 Change-Id: Ied4bf739e2b1a2307f22fc79c1cfad746c8cbc44 Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
2020-05-15 09:38:53 +00:00
if(NOT QT_BUILD_DIR)
message(FATAL_ERROR "No QT_BUILD_DIR value provided to qt-cmake-private-install.")
endif()
CMake: Don't strip debug builds with qt-cmake-private-install in CI This provides better stack traces and easier debugging in CI VMs. Put the MSVC check for disabling stripping into the same place so there's one location to decide whether stripping should happen. Amends 60d804c56769de82e658205bec687b83833a61e9 Pick-to: 6.6 Fixes: QTBUG-118070 Change-Id: I4684036c8a5a137d14eea58954b34fe1ceb7f804 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
2023-10-16 16:04:06 +00:00
if(should_skip_strip)
unset(strip_arg)
else()
set(strip_arg --strip)
Do not strip binaries for MSVC builds CMake's --install --strip command will result in calling ${CMAKE_STRIP} after installation. On the build machines we have multiple compilers, and ${CMAKE_STRIP} will have a valid program e.g. C:/strawberry/c/bin/strip.exe This will change the MSVC binaries to have a MinGW linker version flag, which confuses Qt Creator when setting up a MSVC Kit. Amends 2044992eed3e48909d17a4304ea25d3007d94d60 Fixes: QTBUG-87735 Change-Id: I1b3d4cc122b3f502810d48e0443f39824016cab5 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
2020-10-28 18:35:11 +00:00
endif()
CMake: Don't strip debug builds with qt-cmake-private-install in CI This provides better stack traces and easier debugging in CI VMs. Put the MSVC check for disabling stripping into the same place so there's one location to decide whether stripping should happen. Amends 60d804c56769de82e658205bec687b83833a61e9 Pick-to: 6.6 Fixes: QTBUG-118070 Change-Id: I4684036c8a5a137d14eea58954b34fe1ceb7f804 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
2023-10-16 16:04:06 +00:00
CMake: Use custom install script to support Ninja Multi-Config builds Calling cmake --install . only installs a single configuration. To install both debug and release artifacts, the install invocation needs to be done for each configuration. To keep the Coin instruction code simpler, delegate the looping over configurations to a custom CMake script, and use it in the Coin instructions. Replace all cmake --install calls in the instructions with calls to either call_host_install.yaml or call_target_install.yaml. The path to the script depends on whether we are building qtbase or another module. In the former case the script should be called from the build dir, otherwise from the install dir. The other distinction is whether the host or target env prefix needs to be added. Task-number: QTBUG-80900 Change-Id: Ied4bf739e2b1a2307f22fc79c1cfad746c8cbc44 Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
2020-05-15 09:38:53 +00:00
foreach(config ${configs})
message(STATUS "Installing configuration: '${config}'")
Do not strip binaries for MSVC builds CMake's --install --strip command will result in calling ${CMAKE_STRIP} after installation. On the build machines we have multiple compilers, and ${CMAKE_STRIP} will have a valid program e.g. C:/strawberry/c/bin/strip.exe This will change the MSVC binaries to have a MinGW linker version flag, which confuses Qt Creator when setting up a MSVC Kit. Amends 2044992eed3e48909d17a4304ea25d3007d94d60 Fixes: QTBUG-87735 Change-Id: I1b3d4cc122b3f502810d48e0443f39824016cab5 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
2020-10-28 18:35:11 +00:00
set(args "${CMAKE_COMMAND}" --install ${QT_BUILD_DIR} --config "${config}" ${strip_arg})
CMake: Use custom install script to support Ninja Multi-Config builds Calling cmake --install . only installs a single configuration. To install both debug and release artifacts, the install invocation needs to be done for each configuration. To keep the Coin instruction code simpler, delegate the looping over configurations to a custom CMake script, and use it in the Coin instructions. Replace all cmake --install calls in the instructions with calls to either call_host_install.yaml or call_target_install.yaml. The path to the script depends on whether we are building qtbase or another module. In the former case the script should be called from the build dir, otherwise from the install dir. The other distinction is whether the host or target env prefix needs to be added. Task-number: QTBUG-80900 Change-Id: Ied4bf739e2b1a2307f22fc79c1cfad746c8cbc44 Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
2020-05-15 09:38:53 +00:00
execute_process(COMMAND ${args}
COMMAND_ECHO STDOUT
RESULT_VARIABLE result)
if(NOT "${result}" STREQUAL "0")
message(FATAL_ERROR "Installing configuration '${config}' failed with exit code: ${result}.")
endif()
endforeach()
Reference in New Issue Copy Permalink