AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

QTableView: add an operator<<(QDebug, SpanList)

Browse Source 
Simplifies the code at the call site.

Even though QDebug has support for streaming std::list (SpanList), the
format of the output would be different than what's already used here,
hence the custom operator<<().

Drive-by, port from Q_FOREACH to ranged-for

Task-number: QTBUG-115803
Change-Id: I30953c92e0c9febc01497c1117fa472b4718820e
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
This commit is contained in:
Ahmad Samir 2023-08-07 00:49:29 +03:00
parent 2ec8acf611
commit 006fecc824
1 changed files with 13 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/widgets/itemviews/qtableview.cpp
View File

@ -172,6 +172,13 @@ QDebug operator<<(QDebug str, const QSpanCollection::Span &span)
str << '(' << span.top() << ',' << span.left() << ',' << span.bottom() << ',' << span.right() << ')';
return str;
}
QDebug operator<<(QDebug debug, const QSpanCollection::SpanList &spans)
{
for (const auto *span : spans)
debug << span << *span;
return debug;
}
#endif
/** \internal
@ -202,8 +209,7 @@ void QSpanCollection::updateInsertedRows(int start, int end)
#ifdef DEBUG_SPAN_UPDATE
qDebug("After");
foreach (QSpanCollection::Span *span, spans)
qDebug() << span << *span;
qDebug() << spans;
#endif
for (Index::iterator it_y = index.begin(); it_y != index.end(); ) {
@ -249,8 +255,7 @@ void QSpanCollection::updateInsertedColumns(int start, int end)
#ifdef DEBUG_SPAN_UPDATE
qDebug("After");
foreach (QSpanCollection::Span *span, spans)
qDebug() << span << *span;
qDebug() << spans;
#endif
for (Index::iterator it_y = index.begin(); it_y != index.end(); ++it_y) {
@ -354,8 +359,7 @@ void QSpanCollection::updateRemovedRows(int start, int end)
#ifdef DEBUG_SPAN_UPDATE
qDebug("After");
foreach (QSpanCollection::Span *span, spans)
qDebug() << span << *span;
qDebug() << spans;
#endif
if (spans.empty()) {
qDeleteAll(spansToBeDeleted);
@ -422,8 +426,7 @@ void QSpanCollection::updateRemovedRows(int start, int end)
#ifdef DEBUG_SPAN_UPDATE
qDebug() << index;
qDebug("Deleted");
foreach (QSpanCollection::Span *span, spansToBeDeleted)
qDebug() << span << *span;
qDebug() << spansToBeDeleted;
#endif
qDeleteAll(spansToBeDeleted);
}
@ -481,8 +484,7 @@ void QSpanCollection::updateRemovedColumns(int start, int end)
#ifdef DEBUG_SPAN_UPDATE
qDebug("After");
foreach (QSpanCollection::Span *span, spans)
qDebug() << span << *span;
qDebug() << spans;
#endif
if (spans.empty()) {
qDeleteAll(toBeDeleted);
@ -501,8 +503,7 @@ void QSpanCollection::updateRemovedColumns(int start, int end)
#ifdef DEBUG_SPAN_UPDATE
qDebug() << index;
qDebug("Deleted");
foreach (QSpanCollection::Span *span, toBeDeleted)
qDebug() << span << *span;
qDebug() << toBeDeleted;
#endif
qDeleteAll(toBeDeleted);
}