AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Change "delivering touch to same window" warnings to debug messages

Browse Source 
When you touch-tap a QPushButton, and that opens a popup, it's normal
that the touch release is delivered to the main window rather than the
popup: in fact QWidgetWindow::handleMouseEvent() expects to see a
synth-mouse release. No warning is needed. Amends
efc02f9cc3

There may be other cases when it should have remained a warning (it's
been there since 2692237bb1), but that's
hypothetical at this point.

Pick-to: 6.2 6.3 6.4
Task-number: QTBUG-103706
Change-Id: Ie8cc62af4d173ada5138fd099d9f02bd41f4cff4
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
This commit is contained in:
Shawn Rutledge 2022-07-12 15:54:40 +02:00
parent 593b0a01c5
commit 03a691cecb
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/gui/kernel/qguiapplication.cpp
View File

@ -2893,15 +2893,15 @@ void QGuiApplicationPrivate::processTouchEvent(QWindowSystemInterfacePrivate::To
case QEventPoint::State::Released: case QEventPoint::State::Released:
if (Q_UNLIKELY(!window.isNull() && window != QMutableEventPoint::window(ep))) if (Q_UNLIKELY(!window.isNull() && window != QMutableEventPoint::window(ep)))
qCWarning(lcPtrDispatch) << "delivering touch release to same window" qCDebug(lcPtrDispatch) << "delivering touch release to same window"
<< QMutableEventPoint::window(ep) << "not" << window.data(); << QMutableEventPoint::window(ep) << "not" << window.data();
window = QMutableEventPoint::window(ep); window = QMutableEventPoint::window(ep);
break; break;
default: // update or stationary default: // update or stationary
if (Q_UNLIKELY(!window.isNull() && window != QMutableEventPoint::window(ep))) if (Q_UNLIKELY(!window.isNull() && window != QMutableEventPoint::window(ep)))
qCWarning(lcPtrDispatch) << "delivering touch update to same window" qCDebug(lcPtrDispatch) << "delivering touch update to same window"
<< QMutableEventPoint::window(ep) << "not" << window.data(); << QMutableEventPoint::window(ep) << "not" << window.data();
window = QMutableEventPoint::window(ep); window = QMutableEventPoint::window(ep);
break; break;
} }