AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Move prematureExec() to the end of tst_qsqlquery's testing

Browse Source 
It leaves the system in a state that breaks at least one later test,
so put it last. (This was first seen when picking back to 6.2, but I
am now able to reproduce it on dev.)

Amends commit 78eac57f3d

Pick-to: 6.3
Change-Id: I918cf43cdfc27357329a175518d6f9755747bae5
Reviewed-by: Andy Shaw <andy.shaw@qt.io>
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
This commit is contained in:
Edward Welbourne 2022-02-02 17:24:12 +01:00
parent 0a64a044b6
commit 06942138d6
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/auto/sql/kernel/qsqlquery/tst_qsqlquery.cpp
View File

@ -70,8 +70,6 @@ private slots:
void query_exec();
void execErrorRecovery_data() { generic_data(); }
void execErrorRecovery();
void prematureExec_data() { generic_data(); }
void prematureExec();
void first_data() { generic_data(); }
void first();
void next_data() { generic_data(); }
@ -271,6 +269,10 @@ private slots:
void ibaseArray_data() { generic_data("QIBASE"); }
void ibaseArray();
// Double addDatabase() with same name leaves system in a state that breaks
// invalidQuery() if run later; so put this one last !
void prematureExec_data() { generic_data(); }
void prematureExec();
private:
// returns all database connections
void generic_data(const QString &engine=QString());