AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tst_QStringList: add more checks for removeDuplicates

Browse Source 
Check whether a detach happened, and also check that non-consecutive duplicates
are properly removed.

Change-Id: Iac7a3d8fe5ed5a69a9a0b55ddbf95308f11122c2
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
This commit is contained in:
Marc Mutz 2014-03-28 08:57:11 +01:00 committed by The Qt Project
parent 35ed65b1a9
commit 08b8f9d087
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tests/auto/corelib/tools/qstringlist/tst_qstringlist.cpp
View File

@ -296,9 +296,11 @@ void tst_QStringList::removeDuplicates_data()
QTest::addColumn<QString>("before");
QTest::addColumn<QString>("after");
QTest::addColumn<int>("count");
QTest::addColumn<bool>("detached");
QTest::newRow("empty-1") << "Hello,Hello" << "Hello" << 1;
QTest::newRow("empty-2") << "Hello,World" << "Hello,World" << 0;
QTest::newRow("empty-1") << "Hello,Hello" << "Hello" << 1 << true;
QTest::newRow("empty-2") << "Hello,World" << "Hello,World" << 0 << false;
QTest::newRow("middle") << "Hello,World,Hello" << "Hello,World" << 1 << true;
}
void tst_QStringList::removeDuplicates()
@ -306,13 +308,16 @@ void tst_QStringList::removeDuplicates()
QFETCH(QString, before);
QFETCH(QString, after);
QFETCH(int, count);
QFETCH(bool, detached);
QStringList lbefore = before.split(',');
const QStringList oldlbefore = lbefore;
QStringList lafter = after.split(',');
int removed = lbefore.removeDuplicates();
QCOMPARE(removed, count);
QCOMPARE(lbefore, lafter);
QCOMPARE(detached, !oldlbefore.isSharedWith(lbefore));
}
void tst_QStringList::streamingOperator()