AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve the QWinSettingsPrivate constructor's performance

Browse Source 
This is mainly achieved by modifying the program flow to require
fewer string comparisons and conversions.

Change-Id: I9887623b9c05fe76460fc725d6534d16bd9f9e59
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>
This commit is contained in:
Sebastian Schuberth 2009-12-16 15:33:21 +01:00 committed by The Qt Project
parent dc6852ca63
commit 09a11069e7
1 changed files with 25 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
src/corelib/io/qsettings_win.cpp
View File

@ -433,27 +433,32 @@ QWinSettingsPrivate::QWinSettingsPrivate(QString rPath)
{
deleteWriteHandleOnExit = false;
if (rPath.startsWith(QLatin1String("\\")))
rPath = rPath.mid(1);
if (rPath.startsWith(QLatin1Char('\\')))
rPath.remove(0, 1);
if (rPath.startsWith(QLatin1String("HKEY_CURRENT_USER\\")))
regList.append(RegistryKey(HKEY_CURRENT_USER, rPath.mid(18), false));
else if (rPath == QLatin1String("HKEY_CURRENT_USER"))
regList.append(RegistryKey(HKEY_CURRENT_USER, QString(), false));
else if (rPath.startsWith(QLatin1String("HKEY_LOCAL_MACHINE\\")))
regList.append(RegistryKey(HKEY_LOCAL_MACHINE, rPath.mid(19), false));
else if (rPath == QLatin1String("HKEY_LOCAL_MACHINE"))
regList.append(RegistryKey(HKEY_LOCAL_MACHINE, QString(), false));
else if (rPath.startsWith(QLatin1String("HKEY_CLASSES_ROOT\\")))
regList.append(RegistryKey(HKEY_CLASSES_ROOT, rPath.mid(18), false));
else if (rPath == QLatin1String("HKEY_CLASSES_ROOT"))
regList.append(RegistryKey(HKEY_CLASSES_ROOT, QString(), false));
else if (rPath.startsWith(QLatin1String("HKEY_USERS\\")))
regList.append(RegistryKey(HKEY_USERS, rPath.mid(11), false));
else if (rPath == QLatin1String("HKEY_USERS"))
regList.append(RegistryKey(HKEY_USERS, QString(), false));
else
regList.append(RegistryKey(HKEY_LOCAL_MACHINE, rPath, false));
int keyLength;
HKEY keyName;
if (rPath.startsWith(QLatin1String("HKEY_CURRENT_USER"))) {
keyLength = 17;
keyName = HKEY_CURRENT_USER;
} else if (rPath.startsWith(QLatin1String("HKEY_LOCAL_MACHINE"))) {
keyLength = 18;
keyName = HKEY_LOCAL_MACHINE;
} else if (rPath.startsWith(QLatin1String("HKEY_CLASSES_ROOT"))) {
keyLength = 17;
keyName = HKEY_CLASSES_ROOT;
} else if (rPath.startsWith(QLatin1String("HKEY_USERS"))) {
keyLength = 10;
keyName = HKEY_USERS;
} else {
return;
}
if (rPath.length() == keyLength)
regList.append(RegistryKey(keyName, QString(), false));
else if (rPath[keyLength] == QLatin1Char('\\'))
regList.append(RegistryKey(keyName, rPath.mid(keyLength+1), false));
}
bool QWinSettingsPrivate::readKey(HKEY parentHandle, const QString &rSubKey, QVariant *value) const