AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Drop const from a declaration to let a return move

Browse Source 
CodeChecker points out that QTimeZone::systemTimeZoneId()'s first
attempt saved its result in a const QByteArray, which consequently
wasn't moved from when returning. That doesn't make a huge difference
for a CoW, but might as well skip the const and let the compiler do
the natural thing.

Change-Id: I966c9137505a8188532b164524dd4e05c0b2ac53
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
This commit is contained in:
Edward Welbourne 2022-05-23 15:59:35 +02:00
parent b6be97f65e
commit 0a350eaf25
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/corelib/time/qtimezone.cpp
View File

@ -762,7 +762,7 @@ QTimeZone::OffsetDataList QTimeZone::transitions(const QDateTime &fromDateTime,
QByteArray QTimeZone::systemTimeZoneId()
{
const QByteArray sys = global_tz->backend->systemTimeZoneId();
QByteArray sys = global_tz->backend->systemTimeZoneId();
if (!sys.isEmpty())
return sys;
// The system zone, despite the empty ID, may know its real ID anyway: