AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

udev: Do not overwrite original device pointer

Browse Source 
Overwriting the original device pointer would unref an incorrect
instance during cleanup, resulting to a memory leak.

Change-Id: Ieac4a2de98eec329aa42dedce9601c44348ba4d9
Reviewed-by: Robin Burchell <robin.burchell@viroteck.net>
This commit is contained in:
Mikko Harju 2015-08-17 16:02:57 +03:00 committed by Simon Hausmann
parent c5ceabb9a1
commit 0b1f439cb2
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/platformsupport/devicediscovery/qdevicediscovery_udev.cpp
View File

@ -185,11 +185,11 @@ void QDeviceDiscoveryUDev::handleUDevNotification()
// if we cannot determine a type, walk up the device tree // if we cannot determine a type, walk up the device tree
if (!checkDeviceType(dev)) { if (!checkDeviceType(dev)) {
// does not increase the refcount // does not increase the refcount
dev = udev_device_get_parent_with_subsystem_devtype(dev, subsystem, 0); struct udev_device *parent_dev = udev_device_get_parent_with_subsystem_devtype(dev, subsystem, 0);
if (!dev) if (!parent_dev)
goto cleanup; goto cleanup;
if (!checkDeviceType(dev)) if (!checkDeviceType(parent_dev))
goto cleanup; goto cleanup;
} }