AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

QMdiArea: fix unintended reallocations

Browse Source 
The capacity of 'result' is reserved, but QVector::clear() always
deallocates. Fix by using resize(int) instead, which at least
preserves capacity when it has been reserve()d.

Change-Id: I198d532661f4f767588c4ce244c2454eb8823e54
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@theqtcompany.com>
This commit is contained in:
Marc Mutz 2015-12-03 13:49:33 +01:00
parent b566d670e5
commit 0d1024e0f1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/widgets/widgets/qmdiarea.cpp
View File

@ -512,7 +512,7 @@ QVector<QRect> MinOverlapPlacer::findMaxOverlappers(const QRect &domain, const Q
if (overlap >= maxOverlap || maxOverlap == -1) { if (overlap >= maxOverlap || maxOverlap == -1) {
if (overlap > maxOverlap) { if (overlap > maxOverlap) {
maxOverlap = overlap; maxOverlap = overlap;
result.clear(); result.resize(0);
} }
result << srcRect; result << srcRect;
} }