AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Optimize QAbstractTableModel::hasChildren

Browse Source 
Valid indexes cannot have children, in a table model, so there's no
point in asking the model about it (by calling rowCount and
columnCount).

Change-Id: Ic2d7b52538a7b67acb2c35b26e69bba5956ef5af
Reviewed-by: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Reviewed-by: Christian Ehrlicher <ch.ehrlicher@gmx.de>
This commit is contained in:
David Faure 2019-04-13 15:38:15 +02:00
parent 54ceb8a5f8
commit 20e2861073
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/corelib/itemmodels/qabstractitemmodel.cpp
View File

@ -3618,7 +3618,7 @@ QModelIndex QAbstractTableModel::sibling(int row, int column, const QModelIndex
bool QAbstractTableModel::hasChildren(const QModelIndex &parent) const bool QAbstractTableModel::hasChildren(const QModelIndex &parent) const
{ {
if (parent.model() == this || !parent.isValid()) if (!parent.isValid())
return rowCount(parent) > 0 && columnCount(parent) > 0; return rowCount(parent) > 0 && columnCount(parent) > 0;
return false; return false;
} }