AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

qwindowsdirect2dintegration.cpp: replace QVector with QVarLengthArray

Browse Source 
QVector was used as just RAII for local array. It's inefficient usage
of CoW type. So use QVarLengthArray instead.

Change-Id: I494ecc49af9049569a65e258581137bad3ce7dc7
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
This commit is contained in:
Anton Kudryavtsev 2016-10-19 12:59:18 +03:00 committed by Anton Kudryavtsev
parent bdcc9d4e73
commit 26ac91c832
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/platforms/direct2d/qwindowsdirect2dintegration.cpp
View File

@ -52,6 +52,8 @@
#include <QtGui/qpa/qwindowsysteminterface.h> #include <QtGui/qpa/qwindowsysteminterface.h>
#include <QtEventDispatcherSupport/private/qwindowsguieventdispatcher_p.h> #include <QtEventDispatcherSupport/private/qwindowsguieventdispatcher_p.h>
#include <QVarLengthArray>
QT_BEGIN_NAMESPACE QT_BEGIN_NAMESPACE
class QWindowsDirect2DEventDispatcher : public QWindowsGuiEventDispatcher class QWindowsDirect2DEventDispatcher : public QWindowsGuiEventDispatcher
@ -106,7 +108,7 @@ public:
if (_tcscat_s(filename, bufSize, __TEXT("\\d2d1.dll")) == 0) { if (_tcscat_s(filename, bufSize, __TEXT("\\d2d1.dll")) == 0) {
DWORD versionInfoSize = GetFileVersionInfoSize(filename, NULL); DWORD versionInfoSize = GetFileVersionInfoSize(filename, NULL);
if (versionInfoSize) { if (versionInfoSize) {
QVector<BYTE> info(versionInfoSize); QVarLengthArray<BYTE> info(versionInfoSize);
if (GetFileVersionInfo(filename, NULL, versionInfoSize, info.data())) { if (GetFileVersionInfo(filename, NULL, versionInfoSize, info.data())) {
UINT size; UINT size;
DWORD *fi; DWORD *fi;