AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Speed up tst_QLocalSocket::sendData

Browse Source 
The data function for this test re-used listenAndConnect_data that
has an additional column "connections" which was never used in sendData.
Thus sendData executed three times the same code which is just uselessly
burned CI time.
Copied the actually needed code of listenAndConnect_data to sendData_data.

Change-Id: I6cdb1c1b72cb4ce7be7c13e90eea30ac09a14914
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@theqtcompany.com>
This commit is contained in:
Joerg Bornemann 2016-03-02 16:09:38 +01:00
parent 007039eae9
commit 2b2232b5ea
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/auto/network/socket/qlocalsocket/tst_qlocalsocket.cpp
View File

@ -498,7 +498,11 @@ void tst_QLocalSocket::connectWithOldOpen()
void tst_QLocalSocket::sendData_data()
{
listenAndConnect_data();
QTest::addColumn<QString>("name");
QTest::addColumn<bool>("canListen");
QTest::newRow("null") << QString() << false;
QTest::newRow("tst_localsocket") << "tst_localsocket" << true;
}
void tst_QLocalSocket::sendData()