AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix tautological compare in error checking

Browse Source 
size is size_t, so it's never less than zero.

Fixes: QTBUG-72286
Change-Id: Idd0c85a4e7b64f9c9c7dfffd156d404d0de5ed8d
Reviewed-by: Oliver Wolff <oliver.wolff@qt.io>
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
This commit is contained in:
Thiago Macieira 2018-12-04 14:02:26 -08:00
parent d1cafa3eba
commit 2c6ec2c653
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/corelib/codecs/qwindowscodec.cpp
View File

@ -179,7 +179,7 @@ QString QWindowsLocalCodec::convertToUnicodeCharByChar(const char *chars, int le
#else #else
QString s; QString s;
size_t size = mbstowcs(NULL, mb, length); size_t size = mbstowcs(NULL, mb, length);
if (size < 0) { if (size == size_t(-1)) {
Q_ASSERT("Error in CE TextCodec"); Q_ASSERT("Error in CE TextCodec");
return QString(); return QString();
} }