Removed extra detach calls from QJsonArray::takeAt

Change-Id: I5711ec6b03e3979eca61f62004a7c6f0eaae79e0 Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
2012-06-06 11:43:26 +02:00 · 2012-06-06 11:43:26 +02:00 · 32efe589a3
commit 32efe589a3
parent d2864ffcc0
1 changed files with 1 additions and 6 deletions
--- a/src/corelib/json/qjsonarray.cpp
+++ b/src/corelib/json/qjsonarray.cpp
@ -377,13 +377,8 @@ QJsonValue QJsonArray::takeAt(int i)
    if (!a || i < 0 || i >= (int)a->length)
        return QJsonValue(QJsonValue::Undefined);

-    detach();
-
    QJsonValue v(d, a, a->at(i));
-    v.detach();
-
-    removeAt(i);
-
+    removeAt(i); // detaches
    return v;
 }