AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[QtCore] QDateTime: switch from newRow to addRow in unit tests

Browse Source 
Instead of doing string formating first and then using QTest::newRow,
we can do both at the same time using QTest::addRow

Change-Id: Ia5c90eb705a806e37b96a1fa174a6557f91bee6d
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Andrei Golubev <andrei.golubev@qt.io>
This commit is contained in:
Andreas Buhr 2020-09-09 20:04:59 +02:00
parent 1ab2d8f5eb
commit 3a1dad83ed
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tests/auto/corelib/time/qdatetime/tst_qdatetime.cpp
View File

@ -2018,13 +2018,13 @@ void tst_QDateTime::operator_insert_extract_data()
const QDataStream::Version dataStreamVersion = static_cast<QDataStream::Version>(version);
const QByteArray vN = QByteArray::number(dataStreamVersion);
const QByteArray pY = positiveYear.toString().toLatin1();
QTest::newRow(('v' + vN + " WA => HAWAII " + pY).constData())
QTest::addRow("v%d WA => HAWAII %d", version, 2012)
<< positiveYear << westernAustralia << hawaii << dataStreamVersion;
QTest::newRow(('v' + vN + " WA => WA " + pY).constData())
QTest::addRow("v%d WA => WA %d", version, 2012)
<< positiveYear << westernAustralia << westernAustralia << dataStreamVersion;
QTest::newRow(('v' + vN + " HAWAII => WA " + negativeYear.toString().toLatin1()).constData())
QTest::addRow("v%d HAWAII => WA %d", version, -2012)
<< negativeYear << hawaii << westernAustralia << dataStreamVersion;
QTest::newRow(('v' + vN + " HAWAII => HAWAII " + pY).constData())
QTest::addRow("v%d HAWAII => HAWAII %d", version, 2012)
<< positiveYear << hawaii << hawaii << dataStreamVersion;
}
}