AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

QVariant: write less haphazardly to data

Browse Source 
While the data subobject is at the same position in memory as the
QVariant::Private, using d.data actually activates the union member.

Change-Id: Ie6879b588c8e830ae8b34cfcd8e9ddff8b60b3a6
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
This commit is contained in:
Fabian Kosmale 2021-02-13 17:21:15 +01:00
parent dbab926883
commit 3f9d19b17b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/corelib/kernel/qvariant.cpp
View File

@ -533,9 +533,9 @@ QVariant::QVariant(const QVariant &p)
auto other = p.constData();
if (iface) {
if (other)
iface->copyCtr(iface, &d, other);
iface->copyCtr(iface, &d.data, other);
else
iface->defaultCtr(iface, &d);
iface->defaultCtr(iface, &d.data);
}
}