AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove private QSequentialIterable begin/end methods

Browse Source 
Those are only used by the only friend of the class. As that one can
already poke into QSequentialIteralble's privates, there is no point
in exposing further methods in the public API.

Change-Id: I368e7bcfc43c31f38a42a41a339ff3135d79417c
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
This commit is contained in:
Ulf Hermann 2020-08-21 12:08:58 +02:00
parent f70b955ce8
commit 3fdc08b422
2 changed files with 2 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/corelib/kernel/qvariant.cpp
View File

@ -2591,16 +2591,6 @@ QSequentialIterable::const_iterator::const_iterator(const QtMetaTypePrivate::QSe
ref->ref();
}
void QSequentialIterable::const_iterator::begin()
{
m_impl.moveToBegin();
}
void QSequentialIterable::const_iterator::end()
{
m_impl.moveToEnd();
}
/*! \fn QSequentialIterable::const_iterator QSequentialIterable::begin() const
Returns a QSequentialIterable::const_iterator for the beginning of the container. This
@ -2611,7 +2601,7 @@ void QSequentialIterable::const_iterator::end()
QSequentialIterable::const_iterator QSequentialIterable::begin() const
{
const_iterator it(*this, new QAtomicInt(0));
it.begin();
it.m_impl.moveToBegin();
return it;
}
@ -2624,7 +2614,7 @@ QSequentialIterable::const_iterator QSequentialIterable::begin() const
QSequentialIterable::const_iterator QSequentialIterable::end() const
{
const_iterator it(*this, new QAtomicInt(0));
it.end();
it.m_impl.moveToEnd();
return it;
}

2
src/corelib/kernel/qvariant.h
View File

@ -593,8 +593,6 @@ public:
explicit const_iterator(const QtMetaTypePrivate::QSequentialIterableImpl &impl, QAtomicInt *ref_);
void begin();
void end();
public:
~const_iterator();