AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

QPalette: optimize move assignment operator

Browse Source 
Instead of assigning the various bit-fields manually, use the quint32
union field, which is already present to avoid slow bit-field operations
in the member-swap function.

Verifed that the generated assembly for move-assignment is
significantly better than before on GCC.

Change-Id: If4e0ef678bf3a496c6eb369ad3f639f5a9bc79fc
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
This commit is contained in:
Marc Mutz 2014-02-26 22:33:29 +01:00 committed by The Qt Project
parent 24040ca43c
commit 4051914641
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/gui/kernel/qpalette.h
View File

@ -72,8 +72,7 @@ public:
#ifdef Q_COMPILER_RVALUE_REFS #ifdef Q_COMPILER_RVALUE_REFS
inline QPalette &operator=(QPalette &&other) inline QPalette &operator=(QPalette &&other)
{ {
data.resolve_mask = other.data.resolve_mask; for_faster_swapping_dont_use = other.for_faster_swapping_dont_use;
data.current_group = other.data.current_group;
qSwap(d, other.d); return *this; qSwap(d, other.d); return *this;
} }
#endif #endif