AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Unexport QSslPreSharedKeyAuthenticator

Browse Source 
Exporting value classes (as opposed to just their non-inline
methods) creates subtle binary incompatibility problems.

In this case, between C++11 and C++98 builds because of the
move assignment operator.

Even though it's not a problem in practice, so far, for some
types of classes this issue ie real (QVector, say), so it's
best to avoid exporting what we don't need to export.

Change-Id: Ifca6aaedcbfa79ca35e651de7630e69c3b266fe3
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
This commit is contained in:
Marc Mutz 2015-06-08 16:01:21 +02:00 committed by Jani Heikkinen
parent d0d0ee4ed7
commit 42f5f03d0a
1 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/network/ssl/qsslpresharedkeyauthenticator.h
View File

@ -43,13 +43,13 @@ QT_BEGIN_NAMESPACE
class QSslPreSharedKeyAuthenticatorPrivate;
class Q_NETWORK_EXPORT QSslPreSharedKeyAuthenticator
class QSslPreSharedKeyAuthenticator
{
public:
QSslPreSharedKeyAuthenticator();
~QSslPreSharedKeyAuthenticator();
QSslPreSharedKeyAuthenticator(const QSslPreSharedKeyAuthenticator &authenticator);
QSslPreSharedKeyAuthenticator &operator=(const QSslPreSharedKeyAuthenticator &authenticator);
Q_NETWORK_EXPORT QSslPreSharedKeyAuthenticator();
Q_NETWORK_EXPORT ~QSslPreSharedKeyAuthenticator();
Q_NETWORK_EXPORT QSslPreSharedKeyAuthenticator(const QSslPreSharedKeyAuthenticator &authenticator);
Q_NETWORK_EXPORT QSslPreSharedKeyAuthenticator &operator=(const QSslPreSharedKeyAuthenticator &authenticator);
#ifdef Q_COMPILER_RVALUE_REFS
inline QSslPreSharedKeyAuthenticator &operator=(QSslPreSharedKeyAuthenticator &&authenticator)
@ -61,15 +61,15 @@ public:
d.swap(authenticator.d);
}
QByteArray identityHint() const;
Q_NETWORK_EXPORT QByteArray identityHint() const;
void setIdentity(const QByteArray &identity);
QByteArray identity() const;
int maximumIdentityLength() const;
Q_NETWORK_EXPORT void setIdentity(const QByteArray &identity);
Q_NETWORK_EXPORT QByteArray identity() const;
Q_NETWORK_EXPORT int maximumIdentityLength() const;
void setPreSharedKey(const QByteArray &preSharedKey);
QByteArray preSharedKey() const;
int maximumPreSharedKeyLength() const;
Q_NETWORK_EXPORT void setPreSharedKey(const QByteArray &preSharedKey);
Q_NETWORK_EXPORT QByteArray preSharedKey() const;
Q_NETWORK_EXPORT int maximumPreSharedKeyLength() const;
private:
friend Q_NETWORK_EXPORT bool operator==(const QSslPreSharedKeyAuthenticator &lhs, const QSslPreSharedKeyAuthenticator &rhs);