AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tst_qnetworkreply: unblacklist putWithServerClosingConnectionImmediately

Browse Source 
Looking at grafana it rarely fails in dev so unblacklisting it.
Though it is a little more flaky after switching to http 2 by default
because then we only have one channel and more requests end up queued in
the same channel, which will get errored out when the server
disconnects.

Task-number: QTBUG-88943
Change-Id: If5d6335864ce6bbc35f519b2c6d7068e4181afd2
Reviewed-by: Timur Pocheptsov <timur.pocheptsov@qt.io>
This commit is contained in:
Mårten Nordheim 2020-12-04 17:32:29 +01:00
parent a443cbe7cd
commit 4be6663cf2
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tests/auto/network/access/qnetworkreply/BLACKLIST
View File

@ -16,10 +16,6 @@ ubuntu
windows-10
[putToFtp]
windows-10
[putWithServerClosingConnectionImmediately]
windows-7sp1
windows-10
osx
[backgroundRequest]
macos
[connectToIPv6Address]

3
tests/auto/network/access/qnetworkreply/tst_qnetworkreply.cpp
View File

@ -9077,6 +9077,9 @@ void tst_QNetworkReply::putWithServerClosingConnectionImmediately()
for (int i = 0; i < numUploads; i++) {
// create the request
QNetworkRequest request(QUrl(urlPrefix + QString::number(i)));
// Disable http2 so we get the 6 simultaneous channels as when
// the test was originally written
request.setAttribute(QNetworkRequest::Http2AllowedAttribute, false);
QNetworkReply *reply = manager.put(request, sourceFile);
connect(reply, SIGNAL(sslErrors(QList<QSslError>)), reply, SLOT(ignoreSslErrors()));
connect(reply, SIGNAL(finished()), &server, SLOT(replyFinished()));