AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

qdataurl: extract string literals

Browse Source 
to reuse size() to avoid magic numbers

Change-Id: Id1dc69a024ce5597c2d1468e7cb1470df728d84c
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
This commit is contained in:
Anton Kudryavtsev 2023-09-08 13:18:16 +03:00
parent bb5e3b56db
commit 567bbbb3e9
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/corelib/io/qdataurl.cpp
View File

@ -38,14 +38,16 @@ Q_CORE_EXPORT bool qDecodeDataUrl(const QUrl &uri, QString &mimeType, QByteArray
data = data.trimmed();
// find out if the payload is encoded in Base64
if (QLatin1StringView{data}.endsWith(";base64"_L1, Qt::CaseInsensitive)) {
constexpr auto base64 = ";base64"_L1;
if (QLatin1StringView{data}.endsWith(base64, Qt::CaseInsensitive)) {
payload = QByteArray::fromBase64(payload);
data.chop(7);
data.chop(base64.size());
}
QLatin1StringView textPlain;
if (QLatin1StringView{data}.startsWith("charset"_L1, Qt::CaseInsensitive)) {
qsizetype i = 7; // strlen("charset")
constexpr auto charset = "charset"_L1;
if (QLatin1StringView{data}.startsWith(charset, Qt::CaseInsensitive)) {
qsizetype i = charset.size();
while (data.at(i) == ' ')
++i;
if (data.at(i) == '=')