AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve diagnostics of QPluginLoader test.

Browse Source 
Use QVERIFY2 so that the test output shows the full error string when it
does not contain the expected sub-string.

Change-Id: I31f91bd5c47c082aacabd2333bc12137bc4d24a6
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
This commit is contained in:
Jason McDonald 2011-11-18 17:24:38 +10:00 committed by Qt by Nokia
parent d1e2e2ffbe
commit 572ca43637
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tests/auto/corelib/plugin/qpluginloader/tst_qpluginloader.cpp
View File

@ -263,19 +263,19 @@ void tst_QPluginLoader::loadCorruptElf()
QPluginLoader lib1(SRCDIR "elftest/corrupt1.elf64.so");
QCOMPARE(lib1.load(), false);
QVERIFY(lib1.errorString().contains("not a valid Qt plugin"));
QVERIFY2(lib1.errorString().contains("not a valid Qt plugin"), qPrintable(lib1.errorString()));
QPluginLoader lib2(SRCDIR "elftest/corrupt2.elf64.so");
QCOMPARE(lib2.load(), false);
QVERIFY(lib2.errorString().contains("not a valid Qt plugin"));
QVERIFY2(lib2.errorString().contains("not a valid Qt plugin"), qPrintable(lib2.errorString()));
QPluginLoader lib3(SRCDIR "elftest/corrupt3.elf64.so");
QCOMPARE(lib3.load(), false);
QVERIFY(lib3.errorString().contains("not a valid Qt plugin"));
QVERIFY2(lib3.errorString().contains("not a valid Qt plugin"), qPrintable(lib3.errorString()));
} else if (sizeof(void*) == 4) {
QPluginLoader libW(SRCDIR "elftest/corrupt3.elf64.so");
QCOMPARE(libW.load(), false);
QVERIFY(libW.errorString().contains("architecture"));
QVERIFY2(libW.errorString().contains("architecture"), qPrintable(libW.errorString()));
} else {
QFAIL("Please port QElfParser to this platform or blacklist this test.");
}