AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix usage of linker -no-undefined flag for macOS

Browse Source 
Change-Id: I41c55871a8db3d860fc20ad17eb9a97b01d62448
Reviewed-by: Mikhail Svetkin <mikhail.svetkin@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
This commit is contained in:
Alexandru Croitor 2019-02-27 13:49:04 +01:00
parent c971d2d359
commit 58bd86443c
1 changed files with 15 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
cmake/QtBuild.cmake
View File

@ -200,6 +200,19 @@ function(qt_internal_add_link_flags target to_add)
set_target_properties("${target}" PROPERTIES LINK_FLAGS "${flags}") set_target_properties("${target}" PROPERTIES LINK_FLAGS "${flags}")
endfunction() endfunction()
function(qt_internal_add_link_flags_no_undefined target)
if (GCC OR CLANG)
if(APPLE)
set(no_undefined_flag "-Wl,-undefined,error")
elseif(LINUX)
set(no_undefined_flag "-Wl,--no-undefined")
else()
message(FATAL_ERROR "Platform linker doesn't support erroring upon encountering undefined symbols. Target:\"${target}\".")
endif()
qt_internal_add_link_flags("${target}" "${no_undefined_flag}")
endif()
endfunction()
function(qt_internal_add_linker_version_script target) function(qt_internal_add_linker_version_script target)
qt_parse_all_arguments(arg "qt_internal_add_linker" "INTERNAL" "" "PRIVATE_HEADERS" ${ARGN}) qt_parse_all_arguments(arg "qt_internal_add_linker" "INTERNAL" "" "PRIVATE_HEADERS" ${ARGN})
@ -562,9 +575,7 @@ function(add_qt_module target)
### fixme: cmake is missing a built-in variable for this. We want to apply it only to modules and plugins ### fixme: cmake is missing a built-in variable for this. We want to apply it only to modules and plugins
# that belong to Qt. # that belong to Qt.
if (GCC OR CLANG) qt_internal_add_link_flags_no_undefined("${target}")
qt_internal_add_link_flags("${target}" "-Wl,--no-undefined")
endif()
# When a public module depends on private, also make its private depend on the other's private # When a public module depends on private, also make its private depend on the other's private
set(qt_libs_private "") set(qt_libs_private "")
@ -680,9 +691,7 @@ function(add_qt_plugin target)
### fixme: cmake is missing a built-in variable for this. We want to apply it only to modules and plugins ### fixme: cmake is missing a built-in variable for this. We want to apply it only to modules and plugins
# that belong to Qt. # that belong to Qt.
if (GCC OR CLANG) qt_internal_add_link_flags_no_undefined("${target}")
qt_internal_add_link_flags("${target}" "-Wl,--no-undefined")
endif()
qt_internal_add_linker_version_script(${target}) qt_internal_add_linker_version_script(${target})
endfunction() endfunction()